Modify ↓

Opened 5 days ago

Last modified 42 hours ago

#24993 new enhancement

[patch] Update linux packaging files

Reported by: gaben Owned by: team
Priority: normal Milestone: 26.11
Component: unspecified Version:
Keywords: Cc: stoecker

Description

I noticed the files used on Linux distros are outdated by years and some of the scripts recognizing Java runtime too. Also while doing so, realized a discrepancy in the validator CLI, which is also fixed.

Attachments (2)

1-docs-linux-manpages.patch​ (33.3 KB ) - added by gaben 5 days ago.
2-validator-set.patch​ (4.1 KB ) - added by gaben 5 days ago.

Download all attachments as: .zip

Change History (7)

by gaben, 5 days ago

Attachment: 1-docs-linux-manpages.patch​ added

by gaben, 5 days ago

Attachment: 2-validator-set.patch​ added

comment:1 by gaben, 5 days ago

Two patches attached:

  • 1-docs-linux-manpages.patch updates the Linux packaging. The manpages now match the current --help output: they document the render, project and validate commands, the launcher environment variables (JAVACMD, JAVAFX_HOME, JOSM_MODULEPATH, JOSM_PATH) and have a few more examples.

The launchers know about Java 25-28, the Debian package description and /etc/default files are refreshed, and the unused Docker files are removed. The runjosm help now also mentions the validate command.

  • 2-validator-set.patch fixes josm validate --set key=value, which crashed with an AssertionError because the option was never handled. It now uses the same parsing as runjosm and can be given multiple times. Also includes a unit test.

comment:2 by gaben, 3 days ago

Cc: stoecker added
Keywords: stoecker removed

"Nice". I understand now why I don't receive feedback :)

comment:3 by stoecker, 3 days ago

Don't use these files myself, but on review it looks good to me.

comment:4 by gaben, 2 days ago

Thanks, btw me neither. I bumped into the currently committed version on Arch wiki which is searchable by anyone, and gives an impression that the software is unmaintained (still Java 8? looks bad): ​https://man.archlinux.org/man/josm.1.en

comment:5 by stoecker, 42 hours ago

Milestone: 26.09 → 26.11

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to gaben.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.