Relations not uploaded with UploadSelection, bus routes broken

[Emvee]

I do sometimes Sparse editing and before https://josm.openstreetmap.de/ticket/4142 that was semi-frequently triggering broken bus routes.

Since that patch I did not trigger these problems anymore till recently.

But not I did trigger the problem once more, no sparse edition needed, and it is easy to reproduce:

1) Make some edits where you split a road with a bus route over it
2) Select (for example with lasso-select) all that you want to upload
3) Then do File -> Upload selection
4) The dialog will show you which ways/nodes are uploaded and ask which deleted nodes/ways to include
5) Write the commit message and upload the changes

Now I write it down it is clear what is the problem, josm did nothing wrong, it did update the busroute to include the new way segment, but only the new way segment was uploaded and not the route relation.

So in a sense this is an operator error, I should also have selected the relations and upload that. I do not know a easy way to do that apart from selecting all (modified) relations and I am sure I will forget that now and then.

I think josm could be do a better job here, with a selected upload, ask not only which deleted nodes/ways to include but also which modified relations. I think josm can produce a list of relations that are changes and do have ways/nodes in the selection.

On https://josm.openstreetmap.de/wiki/Help/Action/UploadSelection I read

JOSM completes your selection with additional objects from the local dataset if necessary.

So should that be extended to include changed routes?