Modify

Opened 11 days ago

Closed 3 days ago

Last modified 3 days ago

#24687 closed defect (fixed)

[Patch] JOSM doesn't warn about many moved nodes when rotating or scaling several objects

Reported by: GerdP Owned by: GerdP
Priority: normal Milestone: 26.05
Component: Core Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. (accidentially) select lots of objects which may be outside the visible area
  2. use rotate (Shift+Ctrl+ Mouse move)

What is the expected result?

JOSM should at least warn when more than warn.move.maxelements elements where moved. Preferably all actions which move nodes outside the visible area should trigger a warning.

What happens instead?

No warning at all and likely a lot of misplaced objects.

Please provide any additional information below. Attach a screenshot if possible.

Revision:19553
Is-Local-Build:true
Build-Date:2026-03-25 16:22:25

Identification: JOSM/1.5 (19553 SVN en) Windows 11 64-Bit
OS Build number: Windows 10 Pro 25H2 (26200)
Memory Usage: 3744 MB / 6144 MB (602 MB allocated, but free)
Java version: 21.0.2+13-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.19039, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM HWConsole.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (36474)
+ apache-commons (36474)
+ buildings_tools (36474)
+ comfort0 (36474)
+ ejml (36474)
+ geotools (36474)
+ jackson (36474)
+ jaxb (36474)
+ jts (36474)
+ o5m (36474)
+ opendata (36474)
+ pbf (36474)
+ photo_geotagging (36474)
+ poly (36474)
+ reverter (36474)
+ terracer (36484)
+ undelete (36474)
+ utilsplugin2 (36474)

Tagging presets:
+ c:\josm\core\resources\data\defaultpresets.xml

Map paint styles:
+ c:\josm\core\resources\styles\standard\elemstyles.mapcss

Validator rules:
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss

Last errors/warnings:
- 28847.616 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 28847.616 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 28848.033 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 28848.033 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 28848.698 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 36373.114 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 36373.565 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 36373.622 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 36373.711 W: Not downloading all tiles because there are more than 40 tiles on an axis!
- 36373.773 W: Not downloading all tiles because there are more than 40 tiles on an axis!

Attachments (1)

24687.patch (3.0 KB ) - added by GerdP 10 days ago.
call confirmOrUndoMovement() also after rotating or scaling

Download all attachments as: .zip

Change History (6)

comment:1 by GerdP, 10 days ago

Owner: changed from team to GerdP
Status: newassigned

comment:2 by GerdP, 10 days ago

Milestone: 26.05

by GerdP, 10 days ago

Attachment: 24687.patch added

call confirmOrUndoMovement() also after rotating or scaling

comment:3 by GerdP, 10 days ago

Summary: JOSM doesn't warn about many moved nodes when rotating or scaling several objects[Patch] JOSM doesn't warn about many moved nodes when rotating or scaling several objects

comment:4 by GerdP, 3 days ago

Resolution: fixed
Status: assignedclosed

In 19556/josm:

fix #24687: JOSM doesn't warn about many moved nodes when rotating or scaling several objects

  • add code to call confirmOrUndoMovement() also after rotating or scaling

comment:5 by GerdP, 3 days ago

For me it worked well. Let's see if this causes trouble for someone. If so, I'll add a preference.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.