Changeset 9062 in josm for trunk/src/org/openstreetmap/josm/actions/UploadSelectionAction.java

Timestamp:

2015-11-25T01:21:14+01:00 (10 years ago)

Author:

Don-vip

Message:

Sonar - squid:S1941 - Variables should not be declared before they are relevant

File:

• trunk/src/org/openstreetmap/josm/actions/UploadSelectionAction.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/UploadSelectionAction.java

@@ -101 +101 @@
             }
         }
-        UploadHullBuilder builder = new UploadHullBuilder();
-        UploadSelectionDialog dialog = new UploadSelectionDialog();
         Collection<OsmPrimitive> modifiedCandidates = getModifiedPrimitives(getEditLayer().data.getAllSelected());
         Collection<OsmPrimitive> deletedCandidates = getDeletedPrimitives(getEditLayer().data);
@@ -114 +112 @@
             return;
         }
+        UploadSelectionDialog dialog = new UploadSelectionDialog();
         dialog.populate(
                 modifiedCandidates,
@@ -121 +120 @@
         if (dialog.isCanceled())
             return;
-        Collection<OsmPrimitive> toUpload = builder.build(dialog.getSelectedPrimitives());
+        Collection<OsmPrimitive> toUpload = new UploadHullBuilder().build(dialog.getSelectedPrimitives());
         if (toUpload.isEmpty()) {
             JOptionPane.showMessageDialog(