Changeset 8849 in josm for trunk/src/org/openstreetmap/josm/io/GpxExporter.java

Timestamp:

2015-10-10T14:30:12+02:00 (11 years ago)

Author:

Don-vip

Message:

sonar - squid:S1643 - Strings should not be concatenated using '+' in a loop
sonar - squid:S1640 - Maps with keys that are enum values should be replaced with EnumMap

File:

• trunk/src/org/openstreetmap/josm/io/GpxExporter.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/GpxExporter.java

@@ -318 +318 @@
                 if (answer != JOptionPane.OK_OPTION || l.getSelectedIndex() == -1)
                     return;
-                String license = "";
+                StringBuilder license = new StringBuilder();
                 for (int i : l.getSelectedIndices()) {
                     if (i == 2) {
-                        license = "public domain";
+                        license = new StringBuilder("public domain");
                         break;
                     }
-                    license += license.isEmpty() ? URLS[i] : ", "+URLS[i];
+                    if (license.length() > 0) {
+                        license.append(", ");
+                    }
+                    license.append(URLS[i]);
                 }
-                copyright.setText(license);
+                copyright.setText(license.toString());
                 copyright.setCaretPosition(0);
             }