Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitLayout.java

Timestamp:

2015-10-10T01:40:42+02:00 (11 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitLayout.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitLayout.java

@@ -1158 +1158 @@
             }
         } else {
-            throwParseException(st, "unrecognized attribute \"" + name + "\"");
+            throwParseException(st, "unrecognized attribute \"" + name + '\"');
         }
     }
@@ -1213 +1213 @@
                     parseSplit(st, split);
                 } else {
-                    throwParseException(st, "unrecognized node type '" + nodeType + "'");
+                    throwParseException(st, "unrecognized node type '" + nodeType + '\'');
                 }
             }