Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlCondition.java

Timestamp:

2015-10-10T01:40:42+02:00 (11 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlCondition.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlCondition.java

@@ -22 +22 @@
     public String getKey() {
         if (value != null)
-            return "n" + key + "=" + value;
+            return 'n' + key + '=' + value;
         else if (boolValue != null)
-            return "b" + key  + "=" + OsmUtils.getNamedOsmBoolean(boolValue);
+            return 'b' + key  + '=' + OsmUtils.getNamedOsmBoolean(boolValue);
         else
-            return "x" + key;
+            return 'x' + key;
     }
 
@@ -35 +35 @@
     @Override
     public String toString() {
-      return "Rule["+key+","+(boolValue != null ? "b="+boolValue : "v="+value)+"]";
+      return "Rule["+key+','+(boolValue != null ? "b="+boolValue : "v="+value)+']';
     }