Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

Timestamp:

2015-10-10T01:40:42+02:00 (11 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -262 +262 @@
             try (Formatter us = new Formatter(Locale.US)) {
                 tOffset.setText(us.format(
-                    "%1." + precision + "f; %1." + precision + "f",
+                    "%1." + precision + "f; %1." + precision + 'f',
                     layer.getDx(), layer.getDy()).toString());
             }