Changeset 6240 in josm for trunk/src/org/openstreetmap/josm/data/validation/tests/NameMismatch.java

Timestamp:

2013-09-20T22:44:07+02:00 (13 years ago)

Author:

Don-vip

Message:

Sonar - fix some issues in data.validation.tests

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/NameMismatch.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/NameMismatch.java

@@ -33 +33 @@
     protected static final int NAME_TRANSLATION_MISSING = 1502;
 
+    /**
+     * Constructs a new {@code NameMismatch} test.
+     */
     public NameMismatch() {
         super(tr("Missing name:* translation"),
@@ -59 +62 @@
         for (Entry<String, String> entry : p.getKeys().entrySet()) {
             if (entry.getKey().startsWith("name:")) {
-                String name_s = entry.getValue();
-                if (name_s != null) {
-                    names.add(name_s);
+                String n = entry.getValue();
+                if (n != null) {
+                    names.add(n);
                 }
             }
@@ -74 +77 @@
                     tr("A name is missing, even though name:* exists."),
                     NAME_MISSING, p));
-        return;
-    }
+            return;
+        }
 
         if (names.contains(name)) return;
@@ -82 +85 @@
         Check if this is the case. */
 
-        String[] split_names = name.split(" - ");
-        if (split_names.length == 1) {
+        String[] splitNames = name.split(" - ");
+        if (splitNames.length == 1) {
             /* The name is not composed of multiple parts. Complain. */
             missingTranslation(p);
@@ -90 +93 @@
 
         /* Check that each part corresponds to a translated name:*. */
-        for (String n : split_names) {
+        for (String n : splitNames) {
             if (!names.contains(n)) {
                 missingTranslation(p);