Changeset 2655 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/relation/MemberTableModel.java

Timestamp:

2009-12-19T10:47:49+01:00 (16 years ago)

Author:

jttt

Message:

Fixed #4161 Major slowdown in recent versions, used correct pattern for listeners realized using CopyOnWriteArrayList

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/relation/MemberTableModel.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/relation/MemberTableModel.java

@@ -33 +33 @@
 import org.openstreetmap.josm.data.osm.RelationMember;
 import org.openstreetmap.josm.data.osm.Way;
+import org.openstreetmap.josm.data.osm.event.AbstractDatasetChangedEvent;
 import org.openstreetmap.josm.data.osm.event.DataChangedEvent;
 import org.openstreetmap.josm.data.osm.event.DataSetListener;
@@ -131 +132 @@
 
     public void wayNodesChanged(WayNodesChangedEvent event) {/* ignore */}
+
+    public void otherDatasetChange(AbstractDatasetChangedEvent event) {/* ignore */}
     /* --------------------------------------------------------------------------- */
 
     public void addMemberModelListener(IMemberModelListener listener) {
-        synchronized (listeners) {
-            if (listener != null && !listeners.contains(listener)) {
-                listeners.add(listener);
-            }
+        if (listener != null) {
+            listeners.addIfAbsent(listener);
         }
     }
 
     public void removeMemberModelListener(IMemberModelListener listener) {
-        synchronized (listeners) {
-            if (listener != null && listeners.contains(listener)) {
-                listeners.remove(listener);
-            }
-        }
+        listeners.remove(listener);
     }
 
     protected void fireMakeMemberVisible(int index) {
-        synchronized (listeners) {
-            for (IMemberModelListener listener : listeners) {
-                listener.makeMemberVisible(index);
-            }
+        for (IMemberModelListener listener : listeners) {
+            listener.makeMemberVisible(index);
         }
     }