Changeset 2256 in josm for trunk/src/org/openstreetmap/josm/actions/DuplicateAction.java

Timestamp:

2009-10-09T17:16:54+02:00 (17 years ago)

Author:

Gubaer

Message:

Removed inefficient DataSet:getSelected() when responding to fireSelectionChanged() in JOSM actions, see ​thread on dev
Still uses DataSet:getSelected() when responding to layer change events, this is less critical.

File:

• trunk/src/org/openstreetmap/josm/actions/DuplicateAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/DuplicateAction.java

@@ -7 +7 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.KeyEvent;
+import java.util.Collection;
 
+import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.tools.Shortcut;
 
@@ -22 +24 @@
     }
 
+    @Override
+    protected void updateEnabledState() {
+        if (getCurrentDataSet() == null) {
+            setEnabled(false);
+        } else {
+            updateEnabledState(getCurrentDataSet().getSelected());
+        }
+    }
 
     @Override
-    protected void updateEnabledState() {
-        setEnabled(getCurrentDataSet() != null && ! getCurrentDataSet().getSelected().isEmpty());
+    protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
+        setEnabled(selection != null && !selection.isEmpty());
     }
 }