Changeset 16509 in josm for trunk/src/org/openstreetmap/josm/actions/ChangesetManagerToggleAction.java

Timestamp:

2020-05-27T11:16:39+02:00 (6 years ago)

Author:

GerdP

Message:

see #19296: Actions should avoid to install listeners which are not needed

• either don't call installAdapters() or overwrite listenToSelectionChange()
• partly reverts previous changes so that installAdapters() is not overwritten

One has to be careful because installAdapters() also calls initEnabledState()

File:

• trunk/src/org/openstreetmap/josm/actions/ChangesetManagerToggleAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/ChangesetManagerToggleAction.java

@@ -12 +12 @@
 
 import org.openstreetmap.josm.gui.dialogs.changeset.ChangesetCacheManager;
+import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Shortcut;
 
@@ -26 +27 @@
     public ChangesetManagerToggleAction() {
         super(tr("Changeset Manager"),
-              "dialogs/changeset/changesetmanager",
+                new ImageProvider("dialogs/changeset/changesetmanager").setOptional(true),
               tr("Toggle visibility of Changeset Manager window"),
               Shortcut.registerShortcut("menu:windows:changesetdialog",
                       tr("Toggle visibility of Changeset Manager window"),
                       KeyEvent.VK_C, Shortcut.ALT_CTRL),
-              true /* register shortcut */
+              true /* register shortcut */, null, false
         );
         notifySelectedState();
         changesetCacheManagerClosedHandler = new ChangesetCacheManagerClosedHandler();
         setHelpId(ht("/Dialog/ChangesetManager"));
-    }
-
-    @Override
-    protected void installAdapters() {
-        // do nothing
     }