Opened 7 weeks ago
Last modified 6 days ago
#24924 new enhancement
[patch] Remove Junit 4 last remains
| Reported by: | gaben | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 26.12 |
| Component: | Unit tests | Version: | |
| Keywords: | junit4 | Cc: |
Description
While working on some patches, I noticed that IntelliJ still has ancient Junit4 files on the classpath. I therefore started removing them completely from the core.
I only focused on the core, the core plugins still have to be checked.
FYI: There is an existing ticket for Junit 6 migration (#24921).
Attachments (1)
Change History (7)
comment:1 by , 4 weeks ago
by , 4 weeks ago
| Attachment: | 24924.patch added |
|---|
comment:2 by , 4 weeks ago
| Milestone: | → 26.11 |
|---|---|
| Summary: | Remove Junit 4 last remains → [patch] Remove Junit 4 last remains |
Beware, the patch introduces deprecations, but it should ultimately be leaner and cleaner for everyone in the long term.
Some adjustments will probably be needed.
comment:3 by , 2 weeks ago
If there are no comments regarding the patch, I'll apply the fixes in the next few days (at the start of the next release cycle).
This will be alongside other build-related fixes that I have been moving back and forth on my machine for a while.
comment:6 by , 6 days ago
Please merge: https://github.com/JOSM/markseen/pull/8
Removing JUnit 4 from the core would break the markseen plugin's tests. Fortunately, this does not seem to affect the tests of other plugins, including those hosted on GH. This is either because they declare their own dependencies, or because they do not use functions that are soon to be removed.



Also #23090 should be fixed with the changes.