id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
24031	Strange naming in Mapillary source	stoecker	taylor.smock	"Hello,

I did some cleanup of the [[wiki:DevelopersGuide/ShortcutsList]] and found some issues in Mapillary. I fixed them, but the remaining one is strange:

{{{
    public WebLinkAction(final String name, final URI uri) {
        super(tr(name), ""link"", tr(""Open in browser""),
            Shortcut.registerShortcut(""mapillary:open_in_browser_"" + name.replace(' ', '_'),
                tr(""Mapillary: Open {0} in browser"", tr(name)), KeyEvent.CHAR_UNDEFINED, Shortcut.NONE),
            false, ""mapillary:open_in_browser_"" + name.replace(' ', '_'), false);


        imgLinkAction = new WebLinkAction(marktr(""View in browser""), null);
}}}

results in
/* SHORTCUT(Mapillary: Open View in browser in browser, mapillary:open_in_browser_View_in_browser, CHAR_UNDEFINED, NONE) */

That's a bit strange. I thus left it as is. As it is used only once my proposal would be to move the name ""View in browser"" entirely into the WebLinkAction and don't pass it any arguments. Cleans up the Shortcut parsing and also the names.

P.S. There is another parsing issue in MapRoulette ;-)"	defect	closed	normal		Plugin mapillary		fixed