id summary reporter owner description type status priority milestone component version resolution keywords cc 21907 [WIP-Patch] Update leisure values in sport presets and add one for ice_rink (Was: Remove horse_riding (facility) from preset for sport=horse_racing) Hufkratzer team "==== What steps will reproduce the problem? 1. create a node or an area for a racecourse 2. select the preset for sport=horse_racing 3. open the list for ""Type"" ==== What is the expected result? You should only see things that can be used for horse racing ==== What happens instead? The first entry in the list is horse_riding (facility), see attached screenshot ==== Please provide any additional information below. Attach a screenshot if possible. Tag [https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dhorse_riding leisure=horse_riding] shall **not** be used for racecourses, these should instead be mapped as [https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dsports_centre leisure=sports_centre], see also [https://wiki.openstreetmap.org/wiki/Riding wiki/Riding]. We currently have: - 108 sport=horse_racing + leisure=horse_riding - 445 sport=horse_racing + leisure=pitch - 589 sport=horse_racing + leisure=sports_centre - 121 sport=horse_racing + leisure=stadium - 4533 sport=horse_racing + leisure=track I havn't looked at all the 108 sport=horse_racing + leisure=horse_riding, only at a few; it seems most should rather be tagged with sport=**equestrian** + leisure=horse_riding, but some also with sport=horse_racing + leisure=**sports_centre**, example [https://www.openstreetmap.org/way/181417548 Hypodrome de Jallais]. **CAUTION:** The list of types for sport=horse_racing is currently the same as the one for sport=equestrian, but for sport=equestrian horse_riding (facility) shall remain in the list (see attached screenshot)! **You have to make separate lists** (split chunk id=""riding_surface"" somehow.) A **validator warning** ''""suspicious tag combination - sport=horse_racing together with leisure=horse_riding""'' would also be helpful. ''(The combination sport=horse_racing + leisure=pitch is also quite suspicious, but there are so many of them and I havn't looked at a lot of them yet; so I leave them for later perhaps.)'' {{{ URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022) Build-Date:2022-01-02 20:26:19 Revision:18360 Relative:URL: ^/trunk Identification: JOSM/1.5 (18360 en) Windows 7 64-Bit OS Build number: Windows 7 Home Premium (7601) Memory Usage: 292 MB / 681 MB (130 MB allocated, but free) Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 1024×768 (scaling 1.00×1.00) Maximum Screen Size: 1024×768 Best cursor sizes: 16×16→32×32, 32×32→32×32 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: en_DE Numbers with default locale: 1234567890 -> 1234567890 Dataset consistency test: No problems found Map paint styles: - https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip - https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1 Validator rules: + https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1 + G:\JOSM18360\horse_ridiing.zip Last errors/warnings: - 00022.916 W: Greenhouse Horticulture: Could not get presets icon presets/greenhouse_horticulture.png - 00022.950 E: Failed to locate image 'presets/garages.png' - 00022.951 W: Garages: Could not get presets icon presets/garages.png - 00022.976 E: Failed to locate image 'presets/interpolation.png' - 00022.977 W: Address Interpolation: Could not get presets icon presets/interpolation.png - 00022.997 E: Failed to locate image '' - 00022.997 W: [RELATION] Site: Could not get presets icon - 01661.575 E: Failed to locate image ' ' - 01661.717 E: Failed to locate image '[[Image(pond.png)]]' - 01661.751 E: Failed to locate image '[[Image(oil-palm.png)]]' }}} " enhancement new normal Internal preset sport leisure value horse_riding horse_racing equestrian ice_rink