id summary reporter owner description type status priority milestone component version resolution keywords cc 21889 [PATCH] Java JTable adds a new row to the selection when calling fireTableRowsInserted. This causes us to remove both the new (moved) row and the old (non-moved) row verdyp@… team "==== What steps will reproduce the problem? 1. open the relation editor with any relation containing a few items 2. select any item 3. start dragging them on the list: while your click is maintained you see the Drag-n-drop cursor, and a selected target as a thick cell border between rows 4. release the click: all the selected members are NOT moved to the target selection, in fact they are just removed from the list (if the selection was all members, now all members are removed, but generally for relations with many members, you may not even notice that this removed some members from the list while just trying to select another row) 5. try pressing CTRL+Z to undo: this has no effect in the relation editor. Editing relations with the relation editor and using the mouse to select some items is UNRELIABLE: you can inadvertantly remove items from relations (and it's impossible to undo) ==== What is the expected result? Drag-n-Drop is currently enabled, but NOT implemented at all, it NEVER works in the list of members shown the relation editor. ==== What happens instead? Inadvertantly broken relations with missing members that are silently removed from relations, when one just wanted to select some item (Drag-n-Drop can occur jut because the click may initiate a small drag if the mouse just moves 1 pixel while clicking: selecting rows with the mouse requires absolutely not moving the mouse and this is very unreliable, and even invisible while editing large relations) ==== Please provide any additional information below. Attach a screenshot if possible. This bug has been reported multiple times by since several years, and considered minor, systematically neglected. But it is recurrent in all versions of JOSM since many versions. It causes unexpected loss of information when using the relation editor (most of these being unnoticable by the user). Editing relations with many members with JOSM is still VERY unreliable and dangerous for data. Please admlit that this must be fixed. And because Drag-n-drop has in fact NEVER worked in the relation editor, it should be disabled completely (never accept a drag-n-drop action in the relation editor: so never drop members from the list (if you do that before adding them again, this does not work: the removal has the effect of deleting the references and make them invalid for their reinsertion in the list) {{{ Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2022-01-02 21:24:43 +0100 (Sun, 02 Jan 2022) Revision:18360 Build-Date:2022-01-02 20:26:19 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (18360 fr) Windows 10 64-Bit OS Build number: Windows 10 Pro 2009 (22557) Memory Usage: 3025 MB / 6106 MB (2334 MB allocated, but free) Java version: 11.0.13+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 1680×1050 (scaling 1.00×1.00) \Display1 1920×1080 (scaling 1.00×1.00) Maximum Screen Size: 1920×1080 Best cursor sizes: 16×16→32×32, 32×32→32×32 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: fr_FR Numbers with default locale: 1234567890 -> 1234567890 VM arguments: [-Dicedtea-web.bin.location=C:\Program Files\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop] Dataset consistency test: No problems found Last errors/warnings: - 00000.839 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF' - 00000.844 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF' - 00005.048 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl - 00005.635 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl - 00008.959 W: Unable to request certificate of https://grca.nat.gov.tw }}} " defect closed normal 22.05 Core latest fixed template_report