id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
21722	[patch] Warn about turning_circle with barrier	Famlam	team	"==== What steps will reproduce the problem?
1. Validate a turning circle with a barrier (few hundred cases worldwide). Example: https://www.openstreetmap.org/node/477022939

==== What is the expected result?
Warning: if there's a barrier in the middle of the turning_circle, it's a `turning_loop`; more likely the barrier is directly after leaving the circle and not on the circle, in which case they should be mapped separately.

==== What happens instead?
No warning

==== Please provide any additional information below. Attach a screenshot if possible.

Patch: add the following in combinations.mapcss
{{{
#!rule
node[highway=turning_circle][barrier],
node[highway=turning_loop][barrier] {
	throwWarning: tr(""{0} together with {1}"", ""{0.tag}"", ""{1.key}"");
	group: tr(""suspicious tag combination"");
}
}}}
(or add the selectors here: https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L283 )


{{{
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-01 23:05:46 +0100 (Mon, 01 Nov 2021)
Build-Date:2021-11-01 22:25:18
Revision:18303
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18303 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19044)
Memory Usage: 533 MB / 1820 MB (166 MB allocated, but free)
Java version: 1.8.0_311-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: nl_NL
Numbers with default locale: 1234567890 -> 1234567890

Plugins:
+ OpeningHoursEditor (35640)
+ SimplifyArea (35640)
+ imagery_offset_db (35640)
+ pt_assistant (1ff2e15)
+ reverter (35869)
+ tageditor (35640)
+ turnlanes-tagging (288)
+ undelete (35848)
+ utilsplugin2 (35856)

Tagging presets:
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Presets/NL-Fiets.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Last errors/warnings:
- 00012.752 E: Lokaliseren van afbeelding 'bus.png' mislukt
}}}
"	enhancement	new	normal		Core validator	tested		template_report turning_circle barrier