id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
2153	Changing the interface and not controlling it	luvar@…	framm	"I am uppset, because of changing interface ""PreferenceSetting"" and its method ok, which now should return boolean value. Do you try to catch problems, if someone try to use old plugin? NO! Generated exception is somehow nothing teller.

Please in class org.openstreetmap.josm.gui.preferences.PreferenceDialog rewrite method ok to this:

[code]
    public void ok() {
        boolean requiresRestart = false;
        for (PreferenceSetting setting : settings)
        {
        	try {
        		if(setting.ok())
        			requiresRestart = true;
        	} catch(AbstractMethodError ex) {
        		ex.printStackTrace(System.err);
        		System.err.println(""Preferences of type: "" + setting.getClass().getName() + "" had probably problem with obsolete interface."");
        	}
        }
        if (requiresRestart)
            JOptionPane.showMessageDialog(Main.parent,tr(""You have to restart JOSM for some settings to take effect.""));
        Main.parent.repaint();
    }
[code]"	defect	closed	trivial		Core	latest	fixed	old plugin,changed interface