id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
21351	Gratuitious warning on turn restrictions	pch14@…	team	"Noticed with a no_left_turn restriction, that I get a warning, where the situation in fact is not ambiguous (https://www.openstreetmap.org/relation/12331685). The documentation https://wiki.openstreetmap.org/wiki/Relation:restriction is silent about VIA being an end-point, but indeed, the test is necessary, at least in part.

Pondering the issue, it appears to me, if FROM has VIA as an endpoint, the restriction is unambiguous already, so there is no need to check, if TO has VIA as an endpoint any more. https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/data/validation/tests/TurnrestrictionTest.java#L266 - so I conjectured this:

{{{
+++         if (fromWay.isFirstLastNode(viaNode)) { return; }
            if (!toWay.isFirstLastNode(viaNode)) { …
}}}

Would that really do? Not sure: Will the return skip something? Will restrictions other than ""no…turn"" miss something? Probably an ""else"" before the second if might do as well.

PS: Motivation is, to not make the validator inspire people to split roads even more, than what they already are."	enhancement	new	normal		Core validator			turn restriction