id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
21315	[Patch]Using buildings_tools with a double click produces invalid buildings	ff5722	GerdP	"==== What steps will reproduce the problem?
See also attached .osm file with annotations
1. Draw a building using buildings_tools 
2. Double click at the end so that the building is shaped like a one-dimensional line
...

==== What is the expected result?
A building with width zero is automatically converted to a line object having only 2 nodes. When the user would try to upload, they will be warned for having 'unclosed way - building' anyways, which is easier to fix than duplicated nodes (that requires first merging the nodes and then extruding the building, 2 steps instead of 1).
==== What happens instead?
...
3. Check the result using JOSM validator and note the duplicated nodes error
4. Use the create areas tool (shortcut: X) to fix the 'line' building)
5. The building will still have duplicated nodes, the only way to solve it is to manually merge the dupes
==== Please provide any additional information below. Attach a screenshot if possible.

{{{
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021)
Build-Date:2021-09-03 01:31:19
Revision:18193
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18193 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 2009 (19042)
Memory Usage: 396 MB / 1820 MB (85 MB allocated, but free)
Java version: 1.8.0_301-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1623509627)
+ FastDraw (35640)
+ buildings_tools (35756)
+ terracer (35640)
+ touchscreenhelper (35640)
+ utilsplugin2 (35792)

Tagging presets:
+ <josm.pref>/EasyPresets.xml

Last errors/warnings:
- 00012.432 W: Update plugins - You updated your JOSM software. To prevent problems the plugins should be updated as well.  Update plugins now?
}}}
"	defect	closed	normal		Plugin buildings_tools		fixed	template_report