id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
20442	[PATCH] Normal highway=traffic_signals on junction=roundabout is never correct	mkoniecz	team	"==== What steps will reproduce the problem?
1. Create closed way with `highway=primary` `junction=roundabout`
2. Tag one of its nodes with `highway=traffic_signals`
3. Run validator

==== What is the expected result?
Validator complains ""Normal traffic signals are impossible on roundabout""

==== What happens instead?
Nothing

==== Please provide any additional information below. Attach a screenshot if possible.
""A roundabout is a generally circular (self-intersecting) road junction where the traffic on the roundabout has always right of way."" - so traffic signals are impossible there.

It is a common mistake to tag thing called ""Roundabout ZYX"" for historical reasons (because such junction used to be a roundabout) as junction=roundabout

See https://www.openstreetmap.org/changeset/98319133 where I fixed such incorrect tagging.

Note that `traffic_signals` with value other than `signal` should be skipped.

Note `traffic_signals=continuous_green`, `traffic_signals=emergency` that definitely can appear on roundabout - maybe also other?

{{{
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-01-21 23:33:21 +0100 (Thu, 21 Jan 2021)
Revision:17474
Build-Date:2021-01-22 02:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17474 en) Linux Ubuntu 20.04.1 LTS
Memory Usage: 714 MB / 3974 MB (290 MB allocated, but free)
Java version: 11.0.9.1+1-Ubuntu-0ubuntu1.20.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Desktop environment: LXQt
Java package: openjdk-11-jre:amd64-11.0.9.1+1-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
Environment variable LANG: en_US.UTF-8
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ reverter (35688)
+ todo (30306)

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss
}}}
"	enhancement	closed	normal	21.06	Core validator		fixed	template_report