id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
20380	Toolbar buttons for easypreset-created presets are disabled until you once enter toolbar editing settings panel	pgavrilov	maripogoda	"==== What steps will reproduce the problem?
Bug appears after upgrade JOSM to version 17428

1. Install easypreset plugin
2. Open data layer and create tagged object that you will use as a sample for future preset. Select created object.
3. Create preset using easypreset plugin (menu Presets->Create preset).
4. Rename created preset using easypreset plugin (menu Presets->Manage custom presets) - it is minority bug of easypreset plugin, it creates new preset, but always names it as New Preset
5. Add toolbar button for created preset (menu Edit->Preferences->Toolbar; all easypreset-created presets placed into submenu actions->presets->custom presets)
6. Toolbar button is created and works fine. You can use it to change tagging for any appliable objects.
7. Restart JOSM and open data layer. All created at step 5 buttons are disabled and cannot be used.
8. Open toolbar editing settings panel again (menu Edit->Preferences->Toolbar) and immediately close it by pressing OK.
9. All created at step 5 buttons become enabled and now works fine.


==== What is the expected result?
Before JOSM upgrade to version 17428 was not any strange buttons disabling at JOSM restart.

==== Please provide any additional information below. Attach a screenshot if possible.

{{{
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Build-Date:2020-12-30 02:30:55
Revision:17428
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17428 ru) Windows 7 64-Bit
OS Build number: Windows 7 Professional (7601)
Memory Usage: 786 MB / 1820 MB (105 MB allocated, but free)
Java version: 1.8.0_151-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1,00×1,00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35640)
+ apache-commons (35524)
+ buildings_tools (35669)
+ easypresets (1605041256)
+ imagery_offset_db (35640)
+ photo_geotagging (35640)
+ reltoolbox (35640)
+ utilsplugin2 (35674)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-highways&zip=1
+ C:\Program Files (x86)\JOSM\PG-JOSM-presets.xml
+ https://raw.githubusercontent.com/ruosm-presets/literan-moscow/master/russian_shops.xml

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1

Last errors/warnings:
- 00009,969 E: Не удалось найти изображение «presets\place\isolated_dwelling.svg»
- 00009,970 W:  null: Could not get presets icon presets\place\isolated_dwelling.svg
- 00010,001 E: Не удалось найти изображение «pics/icons/Russian_Post.svg»
- 00010,001 W: [NODE, CLOSEDWAY, MULTIPOLYGON] Russian Post: Could not get presets icon pics/icons/Russian_Post.svg
- 00010,164 E: Испорченная заготовка тегов ""surface-Surface"" - количество элементов в 'display_values' должно быть такое же, как и в 'values'
- 00010,165 E: Подробная информация: [Entry1, Entry2, Entry3] <> [trunk, motorway]
}}}
"	defect	new	minor		Plugin EasyPresets	tested		toolbar preset easypreset button github