id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
19583	[patch] unused icons active-pressed and eye-pressed	Klumbumbus	team	"The icons [[JOSMImage(dialogs/layerlist/active-pressed,middle)]] dialogs/layerlist/active-pressed and [[JOSMImage(dialogs/layerlist/eye-pressed,middle)]] dialogs/layerlist/eye-pressed are actually never used in JOSM, or are they in different OS/LookAndFeel?

They don't make much sense to me anyway.

Is it fine to remove the two icons and these two lines? (These are the two only occurrences of `setPressedIcon` in the whole JOSM code.)

{{{
#!diff
Index: LayerListDialog.java
===================================================================
--- LayerListDialog.java	(revision 16794)
+++ LayerListDialog.java	(working copy)
@@ -465,7 +465,6 @@
             setSelectedIcon(active);
             setRolloverIcon(blank);
             setRolloverSelectedIcon(active);
-            setPressedIcon(ImageProvider.get(""dialogs/layerlist"", ""active-pressed""));
         }
     }
 
@@ -482,7 +481,6 @@
             iconEye = new EyeIcon(/* ICON(dialogs/layerlist/) */ ""eye"");
             iconEyeTranslucent = new EyeIcon(/* ICON(dialogs/layerlist/) */ ""eye-translucent"", true);
             setIcon(ImageProvider.get(""dialogs/layerlist"", ""eye-off""));
-            setPressedIcon(new EyeIcon(/* ICON(dialogs/layerlist/) */ ""eye-pressed""));
             setSelectedIcon(iconEye);
             isTranslucent = false;
         }

}}}


{{{
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-25 14:35:24 +0200 (Sat, 25 Jul 2020)
Build-Date:2020-07-26 01:30:54
Revision:16808
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16808 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 723 MB / 1820 MB (302 MB allocated, but free)
Java version: 1.8.0_251-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1680x1050 (scaling 1.0x1.0)
Maximum Screen Size: 1680x1050
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=49841, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found
}}}
"	enhancement	closed	normal	20.08	Core		fixed	template_report