Opened 6 years ago

Last modified 6 years ago

#19574 closed enhancement

[PATCH] Add a color setting for MapCSS — at Version 1

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 20.08
Component: Core mappaint Version:
Keywords: Cc:

Description (last modified by taylor.smock)

Subpart of #10435.

Possibly significant modifications for plugins:

  • NamedColorProperty extends AbstractToStringProperty<Color>. I'm waiting for a find to get all the instances of NamedColorProperty in plugins, but it is taking awhile (find . -name '*.java' -exec grep -li "NamedColorProperty" {} \;). I don't know if this will require a recompile of any plugins.

Notes:

  • Overrode storeDefaultValue to avoid an NPE. This is required since required final variables are not yet set (a different fix would be to make them non-final).
  • Color boxes are not in the same column as the check marks (I'm not certain this is possible without a lot of work, or even desirable -- there might be a case for a colorboolean setting in the future, for example).

Change History (2)

by taylor.smock, 6 years ago

Attachment: 10435.colors.patch added

Initial colors setting for mapcss

comment:1 by taylor.smock, 6 years ago

Description: modified (diff)

It looks like there are no binary compatibility issues. Or the published Mapillary/UtilsPlugin2 jars didn't throw errors anyway.

Plugins that use NamedColorProperty:

  • splinex
  • FastDraw
  • Mapillary
  • graphview
  • CommandLine
  • cadastre-fr
  • mapwithai
  • utilsplugin2
  • routing
  • buildings_tools
  • MicrosoftStreetside
  • livegps
  • improveway
Last edited 6 years ago by taylor.smock (previous) (diff)
Note: See TracTickets for help on using tickets.