id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
17525	NPE just causes a log message	GerdP	team	"While working on a patch for the reverter plugin I noticed this log message
{{{
2019-03-26 08:54:08.204 SEVERE: Thread main-worker-0 raised java.lang.NullPointerException
}}}
There is no hint in the dialog and no traceback in the log explaining what went wrong. With this small hack I can reproduce the problem easily.
{{{
#!patch
Index: src/reverter/DataSetCommandMerger.java
===================================================================
--- src/reverter/DataSetCommandMerger.java      (revision 34946)
+++ src/reverter/DataSetCommandMerger.java      (working copy)
@@ -106,6 +106,7 @@

         List<Node> newNodes = new ArrayList<>(source.getNodesCount());
         for (Node sourceNode : source.getNodes()) {
+               if (true) sourceNode = null;
             Node targetNode = (Node) getMergeTarget(sourceNode);
             // Target node is not deleted or it will be undeleted when running existing commands
             if (!targetNode.isDeleted() || nominalRevertedPrimitives.contains(targetNode)) {
}}}"	defect	closed	critical		Plugin reverter		fixed		Don-vip