id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
17431	Improve readability of code regarding  OsmDataLayer.validationErrors and ValidatorTreePanel	GerdP	team	"There is a very confusing relation between the field public `OsmDataLayer.validationErrors` and the private field `ValidatorTreePanel.errors`. In some situations both refer to the same instance of ArrayList, but this is not guaranteed by the code. I assume the reason for this are unit tests.
The content of `OsmDataLayer.validationErrors` is directly modified in `ValidateUploadHook` and `ValidatorErrorExporter.exportData()` reads it. 
The content of `OsmDataLayer.validationErrors` is also modified when `ValidatorTreePanel.errors` refers to the same object. This is controlled in `ValidatorDialog`.
My current understanding is that we have a single instance of `ValidatorDialog` and `ValidatorTreePanel` but possibly multiple instances of `OsmDataLayer`, so it seems to be correct to keep the error list in `OsmDataLayer.validationErrors`. 
Question is why we don't use that field in the validator classes?"	enhancement	closed	normal	19.03	Core validator		fixed