id summary reporter owner description type status priority milestone component version resolution keywords cc 16767 fails to parse PH or when is not seperated by after (only valid option) or when present, but accepts and saves some wrong values without warning pirminbraun16@… boman "==== What steps will reproduce the problem? 1. Try to edit valid opening_hours or save invalid ones 2. 3. ==== What is the expected result? parse and display the correct ones and warn about the incorrect ones (see title) simple valid examples would be: Mo12:00-13:00 and 12:00-13:00; PH,Sa 17:00-18:00 and 12:00-13:00, PH 17:00-18:00 and 10:00-19:00; 13:00-14:00 closed invalid examples that are near enough it should probably understand it: Mo 12:00-13:00 (parses, but this is not even valid because and are not separated by a space) Sa,PH 17:00-18:00 (doesn't parse cause of PH, but this is not even valid because must come before ) It should probably also accept a space after the comma after a and between s, as that is widely used, e.g.: Sa, PH 17:00-18:00 reference: https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification#selector:weekday reference: https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification#small_range_selectors So it should understand the first four examples and warn about the last three that they are not according to the specification. ==== What happens instead? doesn't parse correct one and doesn't warn about incorrect ones ==== Please provide any additional information below. Attach a screenshot if possible. {{{ Revision:14268 Is-Local-Build:true Build-Date:2018-09-22 06:01:06 Identification: JOSM/1.5 (14268 SVN en) Linux Arch Linux Memory Usage: 1613 MB / 3974 MB (412 MB allocated, but free) Java version: 10.0.2+13, Oracle Corporation, OpenJDK 64-Bit Server VM Screen: :0.0 1920x1080 Maximum Screen Size: 1920x1080 VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true] Dataset consistency test: No problems found Plugins: + AddrInterpolation (34506) + BuildingGeneralization (23) + CADTools (1007) + Create_grid_of_ways (34499) + CustomizePublicTransportStop (34501) + EasyPresets (1529414338) + ElevationProfile (34576) + FastDraw (34510) + FixAddresses (34511) + ImageWayPoint (34206) + ImproveOsm (143) + ImproveWay (24) + Mapillary (v1.5.16) + MicrosoftStreetside (34627) + OSMRecPlugin (34539) + OpenStreetCam (164) + OpeningHoursEditor (34535) + PicLayer (34544) + RoadSigns (34553) + ShapeTools (1240) + SimplifyArea (34586) + alignways (34489) + apache-commons (34506) + apache-http (34632) + areaselector (349) + austriaaddresshelper (57) + auto_tools (67) + buildings_tools (34572) + changeset-viewer (1537565805) + conflation (0.6.0) + continuosDownload (82) + editgpx (34506) + ejml (34389) + geochat (34512) + geotools (34513) + gpsblam (34515) + gpxfilter (34506) + graphview (34576) + gson (34389) + imagery_offset_db (34641) + jaxb (34506) + jna (34633) + jogl (1.2.2) + jts (34524) + livegps (34526) + log4j (34527) + mapathoner (v0.6.1) + mapdust (34528) + measurement (34529) + native_password_manager (34634) + o5m (34405) + openjfx (34625) + osmarender (34537) + pbf (34576) + pt_assistant (v2.1.5) + public_transport (34548) + public_transport_layer (34549) + reltoolbox (34614) + rex (49) + routes (34479) + routing (34554) + scoutsigns (128) + splinex (34557) + tag2link (34559) + tageditor (34560) + tagging-preset-tester (34561) + todo (30306) + turnlanes-tagging (272) + turnrestrictions (34643) + utilsplugin2 (34506) + wikipedia (v1.1.1) + wms-turbo-challenge2 (34570) Tagging presets: + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/DE.zip + https://josm.openstreetmap.de/josmfile?page=Presets/Surveillance&zip=1 + http://osmtools.de/josm/steps.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Simple_Indoor_Tagging&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1 + https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Diving&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Quick-stops&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Quick-highways&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Tracks&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Playground_Equipment&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/OSMRookie&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/OpenStationMap&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/NewParkingFeatures&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/MobilePhoneBaseStations&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Industrial&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Heritage&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Healthcare&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Drinks&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Community_Centre&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Communication_Towers&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/CommonKeyboardShortcuts&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Camp_site_extends&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Bus_lanes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/BuildingPreset&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Historic_Stone&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/BAR-damage-assessment&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Animal_facilities&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/Allergy&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1 Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1 - https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1 - https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip - https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1 - https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip - https://github.com/GlassOceanos/indoor-JOSM-style/archive/master.zip - https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/BesideTheRoad_Speed&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/BAR-damage-assessment&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Suburb&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Postcode&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Kerbs&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1 - https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss - https://github.com/hotosm/HDM-JOSM-style/archive/master.zip - https://josm.openstreetmap.de/josmfile?page=Styles/HiDPISupport&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Highway_Nodes&zip=1 + https://josm.openstreetmap.de/josmfile?page=Styles/Incline&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/light_source&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/LitObjects&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1 - https://github.com/MissingMaps/josm_styles/archive/master.zip - https://pasharm.github.io/New_basic_style_for_JOSM/New_basic_style.mapcss + https://josm.openstreetmap.de/josmfile?page=Styles/NewHighwayColors&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/NoFeature&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/NumberedCycleNodeNetworks&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1 - https://raw.githubusercontent.com/OpenSidewalks/OpenSidewalks-Schema/master/open_sidewalks.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Potlach2_access&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/PTStops&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/RecyclingMaterials&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Schools&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/RU-SubwayEntranceLabeling&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Noname&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/TreeCrownDiameter&zip=1 - https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss - http://kolesar.turistautak.hu/osm/opencellid/api/styles/cellid.mapcss - http://kolesar.turistautak.hu/osm/opencellid/api/styles/signal-size.mapcss - http://kolesar.turistautak.hu/osm/opencellid/api/styles/measurements.mapcss Validator rules: + https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1 + https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip + https://raw.githubusercontent.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss + https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss + https://www.openrailwaymap.org/validator/de-openrailwaymap.validator.mapcss + https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1 + https://raw.githubusercontent.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss Last errors/warnings: - W: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 20. Encountered: ""P"" (80), after : """" - W: Disable opening hours editor:: java.lang.Exception: Error in the TimeValue. Cause: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 20. Encountered: ""P"" (80), after : """" - W: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 20. Encountered: ""P"" (80), after : """" - W: Disable opening hours editor:: java.lang.Exception: Error in the TimeValue. Cause: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 20. Encountered: ""P"" (80), after : """" - W: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 20. Encountered: ""P"" (80), after : """" - W: Disable opening hours editor:: java.lang.Exception: Error in the TimeValue. Cause: org.openstreetmap.josm.plugins.ohe.parser.TokenMgrError: Lexical error at line 1, column 20. Encountered: ""P"" (80), after : """" - W: org.openstreetmap.josm.plugins.ohe.parser.ParseException: Encountered "" "" "" "" """" at line 1, column 13. - W: Disable opening hours editor:: java.lang.Exception: Error in the TimeValue. Cause: org.openstreetmap.josm.plugins.ohe.parser.ParseException: Encountered "" "" "" "" """" at line 1, column 13. - W: org.openstreetmap.josm.plugins.ohe.parser.ParseException: Encountered "" "" "" "" """" at line 1, column 12. - W: Disable opening hours editor:: java.lang.Exception: Error in the TimeValue. Cause: org.openstreetmap.josm.plugins.ohe.parser.ParseException: Encountered "" "" "" "" """" at line 1, column 12. }}} " defect new normal Plugin openinghourseditor template_report