Poor performance when Command Stack pane is visible

[anonymous]

If I switch the Command Stack pane on and start editing, JOSM keeps leaking more memory. Usually after creating about 200 objects it freezes up and, if I don't kill it soon enough, my laptop freezes as well. Since I have hidden the Command Stack pane I can now edit thousands of objects.

I've observed this issue a couple months ago in a version that was, at the time, the most recent in https://josm.openstreetmap.de/apt artful universe.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-08-22 23:02:00 +0200 (Wed, 22 Aug 2018)
Revision:14180
Build-Date:2018-08-23 01:32:18
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14180 en_GB) Linux Ubuntu 18.04.1 LTS
Memory Usage: 335 MB / 2048 MB (89 MB allocated, but free)
Java version: 10.0.2+13-Ubuntu-1ubuntu0.18.04.2, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1366x768
Maximum Screen Size: 1366x768
Java package: openjdk-11-jre:amd64-10.0.2+13-1ubuntu0.18.04.2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-20ubuntu0.1
VM arguments: [-Djosm.restart=true, -Djosm.dir.name=JOSM-latest, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (34517)
+ PicLayer (34544)
+ alignways (34489)
+ buildings_tools (34572)
+ editgpx (34506)
+ imagery_offset_db (34596)
+ reverter (34552)
+ terracer (34584)
+ utilsplugin2 (34506)

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [WMTS_BLOCK_v2] Resetting cache

[Don-vip]

Status report please.

[anonymous]

Sorry, can you elaborate? What is status report and where to get it from?

[wiktorn]

Looks similar to #12114

[Don-vip]

It's explained in the yellow box when you create a new ticket. If it's there it's meant to be read. It allows us to not have to ask every time what version you're using, your version of Java, your OS, how much memory you have etc.

[Don-vip]

Replying to wiktorn:

Looks similar to #12114

Actually this sounds like #16260

[anonymous]

This really looks like #12114 to me. Unfortunately, despite trying for about an hour with various settings and scenarios, I could no longer reproduce this issue. Before it was very consistent, to the point I was uploading changes when my Undo counter reached 200. 10 more and the machine would freeze. The affected version was from the same repository several months ago.

Partial status report of my current version (working):

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-08-22 23:02:00 +0200 (Wed, 22 Aug 2018)
Revision:14180
Build-Date:2018-08-23 01:32:18
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (14180 en_GB) Linux Ubuntu 18.04.1 LTS
Memory Usage: 335 MB / 2048 MB (89 MB allocated, but free)
Java version: 10.0.2+13-Ubuntu-1ubuntu0.18.04.2, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1366x768
Maximum Screen Size: 1366x768
Java package: openjdk-11-jre:amd64-10.0.2+13-1ubuntu0.18.04.2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-20ubuntu0.1
VM arguments: [-Djosm.restart=true, -Djosm.dir.name=JOSM-latest, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ HouseNumberTaggingTool (34517)
+ PicLayer (34544)
+ alignways (34489)
+ buildings_tools (34572)
+ editgpx (34506)
+ imagery_offset_db (34596)
+ reverter (34552)
+ terracer (34584)
+ utilsplugin2 (34506)

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [WMTS_BLOCK_v2] Resetting cache

[wiktorn]

Replying to anonymous:

This really looks like #12114 to me. Unfortunately, despite trying for about an hour with various settings and scenarios, I could no longer reproduce this issue.

Maybe you've updated your openjdk installation? I've pinpointed this bug to some builds of openjdk, but those (as far as #12114 story goes) were in Debian.

[Don-vip]

It can depend of what exactly you're doing, as not every command will have the same impact on the stack dialog. Can you please tell us if you're mapping POI, highways, landuses, power lines, etc? Adding new stuff, moving nodes, merging ways, deleting stuff, and so on?

[anonymous]

At the time I was experiencing the problem I was mapping mostly buildings (buildings plugin, extrude tool) but it was mostly the number of operations in the stack than anything else that was causing the leak.

I cannot say what openjdk installation I was using 2-3 months ago. I occasionally update Ubuntu packages but I haven't upgraded the distribution itself.