id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
16705	[PATCH] RemoteControlHttpsServer: end mainloop if server.isClosed()	ris	team	"https://github.com/openstreetmap/josm/pull/35

This importantly adds a line

{{{
#!diff
                if (!server.isClosed()) {
                    Logging.error(e);
+               } else {
+                   // stop the thread automatically if server is stopped
+                   return;
                }
}}}

corresponding to a similar line in `RemoteControlHttpServer` which appears to be missing in `RemoteControlHttpsServer`, meaning that a `RemoteControlHttpsServer` thread that's been ""stopped"" would actually just spin forever, erroring on the closed `ServerSocket`.

Also in these patches I've ported the `RemoteControlTest` from `JOSMFixture` to `JOSMTestRules` and improved `AddNodeHandlerTest`'s robustness by giving it the options it needs to be able to properly create a data layer.

And I really ''do'' think this has made appveyor's builds properly reliable now."	defect	closed	normal	18.09	Core remotecontrol		fixed	https stop remotecontrol tests