﻿id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
14545	Open edited pbf file fails	peter.schmiz@…	Don-vip	"==== What steps will reproduce the problem?
1. Download pbf. file  (e.g.: http://download.geofabrik.de/europe/germany/bremen-latest.osm.pbf)
2. Extract area using osmconvert 0.8.5 
{{{osmconvert bremen-latest.osm.pbf -b=8.793526,53.050553,8.851290,53.083560 --complete-ways -o=bremen_extract.osm.pbf}}}
3. Open pbf file in JSOM (File --> Open) (works fine)
4. Edit (e.g. add a node) and save (File --> Save)
5. Delete layer (File --> Delete layer)
6. Open pbf file again (File --> Open) (fails)

==== What is the expected result?

pbf file will be loaded like in step 3.

==== What happens instead?

[[Image(josm_pbf_import_fails.png)]]

Loading fails. Gives me the following error log:

{{{
2017-03-20 15:36:27.074 INFO: Open file: /home/peter/Downloads/osm_extract_1489670759.osm.pbf (208568 bytes)
2017-03-20 15:36:27.084 SEVERE: org.openstreetmap.josm.io.IllegalDataException: java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,554.. Cause: java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,554.
org.openstreetmap.josm.io.IllegalDataException: java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,554.
	at org.openstreetmap.josm.plugins.pbf.io.PbfReader.parseDataSet(PbfReader.java:333)
	at org.openstreetmap.josm.plugins.pbf.io.PbfImporter.parseDataSet(PbfImporter.java:30)
	at org.openstreetmap.josm.io.OsmImporter.loadLayer(OsmImporter.java:113)
	at org.openstreetmap.josm.io.OsmImporter.importData(OsmImporter.java:90)
	at org.openstreetmap.josm.io.OsmImporter.importData(OsmImporter.java:75)
	at org.openstreetmap.josm.io.FileImporter.importDataHandleExceptions(FileImporter.java:90)
	at org.openstreetmap.josm.actions.OpenFileAction$OpenFileTask.importData(OpenFileAction.java:349)
	at org.openstreetmap.josm.actions.OpenFileAction$OpenFileTask.realRun(OpenFileAction.java:302)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:93)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:141)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,554.
	at org.openstreetmap.josm.data.osm.OsmPrimitive.<init>(OsmPrimitive.java:159)
	at org.openstreetmap.josm.data.osm.OsmPrimitive.<init>(OsmPrimitive.java:186)
	at org.openstreetmap.josm.data.osm.Node.<init>(Node.java:179)
	at org.openstreetmap.josm.plugins.pbf.io.PbfReader$PbfParser.parseDense(PbfReader.java:147)
	at crosby.binary.BinaryParser.parse(BinaryParser.java:124)
	at crosby.binary.BinaryParser.handleBlock(BinaryParser.java:68)
	at crosby.binary.file.FileBlock.process(FileBlock.java:135)
	at crosby.binary.file.BlockInputStream.process(BlockInputStream.java:34)
	at org.openstreetmap.josm.plugins.pbf.io.PbfReader.parse(PbfReader.java:340)
	at org.openstreetmap.josm.plugins.pbf.io.PbfReader.parseDataSet(PbfReader.java:323)
	... 14 more

2017-03-20 15:36:27.105 SEVERE: Error - <html>Could not read file 'osm_extract_1489670759.osm.pbf'.<br>Error is:<br>java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,554.</html>
}}}

==== Please provide any additional information below. Attach a screenshot if possible.

{{{
URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-02-26 23:10:22 +0100 (Sun, 26 Feb 2017)
Build-Date:2017-02-26 22:34:39
Revision:11639
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11639 en) Linux Ubuntu 14.04.5 LTS
Memory Usage: 1492 MB / 3522 MB (396 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-3~14.04.1-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 2560x1440
Maximum Screen Size: 2560x1440
Java package: openjdk-8-jre:amd64-8u111-b14-3~14.04.1
Java ATK Wrapper package: libatk-wrapper-java:all-0.30.4-4
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (33004)
+ o5m (33164)
+ pbf (33165)
+ scripting (30764)

Last errors/warnings:
- E: org.openstreetmap.josm.plugins.PluginListParseException: Failed to create plugin information from manifest for plugin 'mbtiles.jar'. Cause: org.openstreetmap.josm.plugins.PluginException: An error occurred in plugin mbtiles. Cause: java.io.IOException: invalid manifest format
- E: org.openstreetmap.josm.io.IllegalDataException: java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,482.. Cause: java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,482.
- E: Error - <html>Could not read file 'osm_extract_1489670759.osm.pbf'.<br>Error is:<br>java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,482.</html>
- E: org.openstreetmap.josm.io.IllegalDataException: java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,490.. Cause: java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,490.
- E: Error - <html>Could not read file 'osm_extract_1489670759.osm.pbf'.<br>Error is:<br>java.lang.IllegalArgumentException: Expected ID >= 0. Got -30,490.</html>
}}}
"	defect	closed	normal		Plugin pbf	tested	fixed	template_report, pbf	
