id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
12335	ExtrudeAction causes NullPointerException if dual alignment setting is toggled without active layer, improve other enabled states	kolesar	team	"==== What steps will reproduce the problem?
1. Create a new empty layer in JOSM. (Ctrl+N)
2. Delete this layer.
3. Click Edit / Dual alignment.

==== What is the expected result?
Dual alignment checkbox changes.

==== What happens instead?
NullPointerException

==== Please provide any additional information below. Attach a screenshot if possible.
Line #366 should be deleted from core/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.orig.java (tested, attached patch). Call updateStatusLine() on toggle is not needed, even confuses user because it says in status line that Extrude (with or without dual alignment) is the active tool while it is not.

""Drag a way segment to make a rectangle. Ctrl-drag to move a segment along its normal, Alt-drag to create a new rectangle, double click to add a new node. Dual alignment active.""

{{{
URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-06 17:30:31 +0100 (Wed, 06 Jan 2016)
Build-Date:2016-01-06 16:32:31
Revision:9329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9329 en) Linux Ubuntu 15.10
Memory Usage: 281 MB / 672 MB (204 MB allocated, but free)
Java version: 1.8.0_66, Oracle Corporation, Java HotSpot(TM) Server VM


Last errors/warnings:
- E: java.lang.NullPointerException
- W: java.net.UnknownHostException: josm.openstreetmap.de
- W: Unable to detect latest version of JOSM: josm.openstreetmap.de

java.lang.NullPointerException
	at org.openstreetmap.josm.actions.mapmode.MapMode.updateStatusLine(MapMode.java:78)
	at org.openstreetmap.josm.actions.mapmode.ExtrudeAction.toggleDualAlign(ExtrudeAction.java:366)
	at org.openstreetmap.josm.actions.mapmode.ExtrudeAction.access$000(ExtrudeAction.java:62)
	at org.openstreetmap.josm.actions.mapmode.ExtrudeAction$DualAlignChangeAction.actionPerformed(ExtrudeAction.java:199)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.JToggleButton$ToggleButtonModel.setPressed(JToggleButton.java:308)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:833)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:877)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6535)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
	at java.awt.Component.processEvent(Component.java:6300)
	at java.awt.Container.processEvent(Container.java:2236)
	at java.awt.Component.dispatchEventImpl(Component.java:4891)
	at java.awt.Container.dispatchEventImpl(Container.java:2294)
	at java.awt.Component.dispatchEvent(Component.java:4713)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
	at java.awt.Container.dispatchEventImpl(Container.java:2280)
	at java.awt.Window.dispatchEventImpl(Window.java:2750)
	at java.awt.Component.dispatchEvent(Component.java:4713)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.awt.EventQueue$4.run(EventQueue.java:729)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

}}}
"	defect	closed	normal	16.02	Core	tested	fixed	template_report