Index: trunk/tools/checkstyle/.classpath
===================================================================
--- trunk/tools/checkstyle/.classpath	(revision 12586)
+++ trunk/tools/checkstyle/.classpath	(revision 12586)
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
+	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
+	<classpathentry kind="src" path="src/"/>
+	<classpathentry kind="output" path="target/classes"/>
+</classpath>
Index: trunk/tools/checkstyle/.project
===================================================================
--- trunk/tools/checkstyle/.project	(revision 12586)
+++ trunk/tools/checkstyle/.project	(revision 12586)
@@ -0,0 +1,46 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>JOSM-Checkstyle-Eclipse-Plugin</name>
+	<comment></comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.jdt.core.javabuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.ManifestBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.SchemaBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.maven.ide.eclipse.maven2Builder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.m2e.core.maven2Builder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.m2e.core.maven2Nature</nature>
+		<nature>org.maven.ide.eclipse.maven2Nature</nature>
+		<nature>org.eclipse.pde.PluginNature</nature>
+		<nature>org.eclipse.jdt.core.javanature</nature>
+		<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
+	</natures>
+</projectDescription>
Index: trunk/tools/checkstyle/.settings/org.eclipse.core.resources.prefs
===================================================================
--- trunk/tools/checkstyle/.settings/org.eclipse.core.resources.prefs	(revision 12586)
+++ trunk/tools/checkstyle/.settings/org.eclipse.core.resources.prefs	(revision 12586)
@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+encoding/<project>=UTF-8
Index: trunk/tools/checkstyle/.settings/org.eclipse.jdt.core.prefs
===================================================================
--- trunk/tools/checkstyle/.settings/org.eclipse.jdt.core.prefs	(revision 12586)
+++ trunk/tools/checkstyle/.settings/org.eclipse.jdt.core.prefs	(revision 12586)
@@ -0,0 +1,11 @@
+eclipse.preferences.version=1
+org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8
+org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
+org.eclipse.jdt.core.compiler.compliance=1.8
+org.eclipse.jdt.core.compiler.debug.lineNumber=generate
+org.eclipse.jdt.core.compiler.debug.localVariable=generate
+org.eclipse.jdt.core.compiler.debug.sourceFile=generate
+org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
+org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
+org.eclipse.jdt.core.compiler.source=1.8
Index: trunk/tools/checkstyle/META-INF/MANIFEST.MF
===================================================================
--- trunk/tools/checkstyle/META-INF/MANIFEST.MF	(revision 12586)
+++ trunk/tools/checkstyle/META-INF/MANIFEST.MF	(revision 12586)
@@ -0,0 +1,19 @@
+Manifest-Version: 1.0
+Bundle-ManifestVersion: 2
+Bundle-Name: JOSM Checkstyle Eclipse Plugin
+Bundle-SymbolicName: org.openstreetmap.josm.checkstyle-eclipse-plugin;singleton:=true
+Bundle-Version: 8.0.0.qualifier
+Require-Bundle: net.sf.eclipsecs.checkstyle,
+ net.sf.eclipsecs.core,
+ net.sf.eclipsecs.ui
+Bundle-RequiredExecutionEnvironment: JavaSE-1.8
+Bundle-ActivationPolicy: lazy
+Eclipse-LazyStart: true
+Bundle-Vendor: https://josm.openstreetmap.de/
+Import-Package: org.eclipse.core.resources,
+ org.eclipse.jdt.core.dom,
+ org.eclipse.jface.resource,
+ org.eclipse.jface.text,
+ org.eclipse.swt.graphics,
+ org.eclipse.ui
+
Index: trunk/tools/checkstyle/build.properties
===================================================================
--- trunk/tools/checkstyle/build.properties	(revision 12586)
+++ trunk/tools/checkstyle/build.properties	(revision 12586)
@@ -0,0 +1,8 @@
+source.. = src/
+bin.includes = META-INF/,\
+               .,\
+               plugin.xml,\
+               josm_checks.xml,\
+               josm_filters.xml
+bin.excludes = checkstyle-all.jar
+               
Index: trunk/tools/checkstyle/plugin.xml
===================================================================
--- trunk/tools/checkstyle/plugin.xml	(revision 12586)
+++ trunk/tools/checkstyle/plugin.xml	(revision 12586)
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<?eclipse version="3.4"?>
+<plugin>
+
+    <!-- This plugin provides custom Checkstyle modules. -->
+    <extension
+          point="net.sf.eclipsecs.core.checkstyleAddonProvider">
+    </extension>
+    
+    <!-- This plugin provides custom quickfixes for Checkstyle problems.
+    <extension
+          point="net.sf.eclipsecs.ui.checkstyleQuickfixProvider">
+    </extension>-->
+
+    <!-- 
+        builtin check configuration
+    -->
+    <extension
+        id="checkstyle.CheckConfiguration"
+        point="net.sf.eclipsecs.core.configurations">
+        <check-configuration
+            name="JOSM Checkstyle checks"
+            location="josm_checks.xml"
+            description="JOSM Checkstyle checks"
+            default-weight="2">
+        </check-configuration>
+    </extension>
+
+    <!-- 
+        checkstyle plugin filter
+    
+    <extension
+        id="checkstyle.CheckstyleFilters"
+        point="net.sf.eclipsecs.core.filters">
+        <filter
+            name="Sample Filter"
+            internal-name="SampleFilter"
+            description="Sample Filter (doing nothing)"
+            class="net.sf.eclipsecs.sample.filter.SampleFilter"/>
+    </extension>-->
+</plugin>
Index: trunk/tools/checkstyle/src/checkstyle_packages.xml
===================================================================
--- trunk/tools/checkstyle/src/checkstyle_packages.xml	(revision 12586)
+++ trunk/tools/checkstyle/src/checkstyle_packages.xml	(revision 12586)
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!DOCTYPE checkstyle-packages PUBLIC
+    "-//Puppy Crawl//DTD Package Names 1.0//EN"
+    "http://www.puppycrawl.com/dtds/packages_1_0.dtd">
+
+<checkstyle-packages>
+    <!--
+      Define the Java packages where your custom Checkstyle module classes (checks, filters) reside here.
+      See http://checkstyle.sourceforge.net/config.html#Packages for more info.
+      -->
+    <package name="org.openstreetmap.josm">
+    </package>
+</checkstyle-packages>
Index: trunk/tools/checkstyle/src/org/openstreetmap/josm/TopLevelJavadocCheck.java
===================================================================
--- trunk/tools/checkstyle/src/org/openstreetmap/josm/TopLevelJavadocCheck.java	(revision 12586)
+++ trunk/tools/checkstyle/src/org/openstreetmap/josm/TopLevelJavadocCheck.java	(revision 12586)
@@ -0,0 +1,95 @@
+// License: GPL. For details, see LICENSE file.
+package org.openstreetmap.josm;
+
+import com.puppycrawl.tools.checkstyle.JavadocDetailNodeParser;
+import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
+import com.puppycrawl.tools.checkstyle.api.DetailAST;
+import com.puppycrawl.tools.checkstyle.api.DetailNode;
+import com.puppycrawl.tools.checkstyle.api.JavadocTokenTypes;
+import com.puppycrawl.tools.checkstyle.api.TokenTypes;
+import com.puppycrawl.tools.checkstyle.utils.JavadocUtils;
+
+/**
+ * Checks that there is Javadoc for every top level class, interface or enum.
+ */
+public class TopLevelJavadocCheck extends AbstractCheck {
+
+    private boolean foundTopLevelClass;
+
+    @Override
+    public int[] getAcceptableTokens() {
+        return getDefaultTokens();
+    }
+
+    @Override
+    public int[] getDefaultTokens() {
+        return new int[]{TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.ENUM_DEF};
+    }
+
+    @Override
+    public int[] getRequiredTokens() {
+        return new int[0];
+    }
+
+    @Override
+    public boolean isCommentNodesRequired() {
+        return true;
+    }
+
+    @Override
+    public void beginTree(DetailAST rootAST) {
+        foundTopLevelClass = false;
+    }
+
+    @Override
+    public void finishTree(DetailAST rootAST) {
+        if (!foundTopLevelClass) {
+            this.log(rootAST.getLineNo(), "assertion failure: unable to find toplevel class or interface");
+        }
+    }
+
+    private boolean hasJavadoc(DetailAST ast) {
+        DetailAST blockCommentBegin = ast.findFirstToken(TokenTypes.BLOCK_COMMENT_BEGIN);
+        if (blockCommentBegin == null) {
+            DetailAST modifiers = ast.findFirstToken(TokenTypes.MODIFIERS);
+            if (modifiers == null)
+                return false;
+            blockCommentBegin = modifiers.findFirstToken(TokenTypes.BLOCK_COMMENT_BEGIN);
+            if (blockCommentBegin == null) {
+                DetailAST annotation = modifiers.findFirstToken(TokenTypes.ANNOTATION);
+                if (annotation == null)
+                    return false;
+                blockCommentBegin = annotation.findFirstToken(TokenTypes.BLOCK_COMMENT_BEGIN);
+                if (blockCommentBegin == null)
+                    return false;
+            }
+        }
+        if (!JavadocUtils.isJavadocComment(blockCommentBegin))
+            return false;
+        DetailNode javadocTree = new JavadocDetailNodeParser().parseJavadocAsDetailNode(blockCommentBegin).getTree();
+        return hasProperText(javadocTree);
+    }
+
+    private boolean hasProperText(DetailNode javadoc) {
+        for (DetailNode child : javadoc.getChildren()) {
+            if (child.getType() == JavadocTokenTypes.TEXT) {
+                if (!child.getText().trim().isEmpty())
+                    return true;
+            } else if (child.getType() == JavadocTokenTypes.HTML_ELEMENT) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    @Override
+    public void visitToken(DetailAST ast) {
+        DetailAST parent = ast.getParent();
+        if (parent == null || parent.getType() == TokenTypes.EOF) {
+            foundTopLevelClass = true;
+            if (!hasJavadoc(ast)) {
+                this.log(ast.getLineNo(), "no/incomplete Javadoc for top level class or interface");
+            }
+        }
+   }
+}
Index: trunk/tools/checkstyle/src/org/openstreetmap/josm/checkstyle-metadata.properties
===================================================================
--- trunk/tools/checkstyle/src/org/openstreetmap/josm/checkstyle-metadata.properties	(revision 12586)
+++ trunk/tools/checkstyle/src/org/openstreetmap/josm/checkstyle-metadata.properties	(revision 12586)
@@ -0,0 +1,4 @@
+JosmCustomChecks.desc = JOSM custom Checkstyle modules.
+
+TopLevelJavadoc.name = Top-Level Javadoc
+TopLevelJavadoc.desc = Checks that there is Javadoc for every top level class, interface or enum
Index: trunk/tools/checkstyle/src/org/openstreetmap/josm/checkstyle-metadata.xml
===================================================================
--- trunk/tools/checkstyle/src/org/openstreetmap/josm/checkstyle-metadata.xml	(revision 12586)
+++ trunk/tools/checkstyle/src/org/openstreetmap/josm/checkstyle-metadata.xml	(revision 12586)
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE checkstyle-metadata PUBLIC
+"-//eclipse-cs//DTD Check Metadata 1.1//EN"
+"http://eclipse-cs.sourceforge.net/dtds/checkstyle-metadata_1_1.dtd">
+<checkstyle-metadata>
+    <rule-group-metadata name="JOSM custom checks"  priority="1600">
+        <description>%JosmCustomChecks.desc</description>
+
+        <rule-metadata name="%TopLevelJavadoc.name" internal-name="TopLevelJavadoc" parent="TreeWalker">
+            <alternative-name internal-name="org.openstreetmap.josm.TopLevelJavadocCheck" />
+            <description>%TopLevelJavadoc.desc</description>
+        </rule-metadata>
+    </rule-group-metadata>
+</checkstyle-metadata>
Index: trunk/tools/checkstyle/src/org/openstreetmap/josm/messages.properties
===================================================================
--- trunk/tools/checkstyle/src/org/openstreetmap/josm/messages.properties	(revision 12586)
+++ trunk/tools/checkstyle/src/org/openstreetmap/josm/messages.properties	(revision 12586)
@@ -0,0 +1,1 @@
+