Ticket #5017: 5017.patch

src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -42 +42 @@
 import org.openstreetmap.josm.data.validation.tests.SelfIntersectingWay;
 import org.openstreetmap.josm.data.validation.tests.SimilarNamedWays;
 import org.openstreetmap.josm.data.validation.tests.TagChecker;
+import org.openstreetmap.josm.data.validation.tests.TagCombinations;
 import org.openstreetmap.josm.data.validation.tests.TurnrestrictionTest;
 import org.openstreetmap.josm.data.validation.tests.UnclosedWays;
 import org.openstreetmap.josm.data.validation.tests.UnconnectedWays;
@@ -101 +102 @@
         BuildingInBuilding.class, // ID 2001 .. 2099
         DeprecatedTags.class, // ID 2101 .. 2199
         OverlappingAreas.class, // ID 2201 .. 2299
+        TagCombinations.class, // ID 2401 .. 2499
     };
 
     public OsmValidator() {

new file src/org/openstreetmap/josm/data/validation/tests/TagCombinations.java

@@ +1 @@
+package org.openstreetmap.josm.data.validation.tests;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashSet;
+import org.openstreetmap.josm.data.osm.Node;
+import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.osm.Relation;
+import org.openstreetmap.josm.data.osm.Way;
+import org.openstreetmap.josm.data.validation.Severity;
+import static org.openstreetmap.josm.tools.I18n.tr;
+
+import org.openstreetmap.josm.data.validation.Test;
+import org.openstreetmap.josm.data.validation.TestError;
+
+public class TagCombinations extends Test {
+
+    private static final Collection<String> IMPLIES_HIGHWAY = new HashSet<String>(Arrays.asList(
+            "surface,oneway,lanes,maxspeed,tracktype,name_1,lit,junction,sac_scale,int_ref,motor_vehicle,segregated,route_ref,smoothness,living_street,trail_visibility,sidewalk,name_2,nat_ref,toll,old_ref,  motorroad,lcn,incline,review,zip_left,zip_right,unsigned_ref,snowplowing,old_ref_legislative,ntd_id,maintenance,trolley_wire,ncn_ref,sorting_name,median,ref_name,moped,step_count".
+            split(",")));
+    private static final Collection<String> IMPLIES_RAILWAY = new HashSet<String>(Arrays.asList(
+            "electrified,gauge,tracks,usage,old_railway_operator,detail,traffic_mode,etcs,eddy_current_brake,tilting_technology,pzb,lzb,grade_of_track,radio,structure_gauge,track_class,operating_procedure,  combined_transport_c,kursbuchstrecke,workrules".
+            split(",")));
+    private static final Collection<String> IMPLIES_WATERWAY = new HashSet<String>(Arrays.asList(
+            "stream,intermittent,boat,length_unit,llid,canal,have_riverbank".split(",")));
+    private static final Collection<String> IMPLIES_ANY_WAY = new HashSet<String>(Arrays.asList(
+            "tunnel,bridge,width,psv".split(",")));
+
+    /* QUERY for taginfo database to get keys for IMPLIES_HIGHWAY, IMPLIES_RAILWAY, IMPLIES_WATERWAY
+    select
+    keypairs.key1,
+    keypairs.key2,
+    keypairs.count_all,
+    keys.count_all,
+    cast(keypairs.count_all as real)/keys.count_all as from_fraction_all
+    from keys, keypairs
+    where
+    key1='waterway' and
+    keys.key=keypairs.key2 and
+    (key1<>'highway' or keypairs.count_all>12000) and
+    (key1<>'railway' or keypairs.count_all>3000) and
+    (key1<>'waterway' or keypairs.count_all>800) and
+    key2 not like '%:%' and
+    from_fraction_all>0.97 and
+    1
+    union select
+    keypairs.key2,
+    keypairs.key1,
+    keypairs.count_all,
+    keys.count_all,
+    cast(keypairs.count_all as real)/keys.count_all as from_fraction_all
+    from keys, keypairs
+    where
+    key2='waterway' and
+    keys.key=keypairs.key1 and
+    (key2<>'highway' or keypairs.count_all>12000) and
+    (key2<>'railway' or keypairs.count_all>3000) and
+    (key2<>'waterway' or keypairs.count_all>800) and
+    key1 not like '%:%' and
+    from_fraction_all>0.97 and
+    1
+    order by keypairs.count_all
+    desc limit 1000;
+     */
+
+    public TagCombinations() {
+        super(tr("Common tag combinations"));
+    }
+
+    public void visit(OsmPrimitive p) {
+        for (String key : p.keySet()) {
+            if (IMPLIES_HIGHWAY.contains(key) && !p.hasKey("highway")) {
+                addError(p, key, "highway");
+            }
+            if (IMPLIES_RAILWAY.contains(key) && !p.hasKey("railway")) {
+                addError(p, key, "railway");
+            }
+            if (IMPLIES_WATERWAY.contains(key) && !p.hasKey("waterway")) {
+                addError(p, key, "waterway");
+            }
+            if (IMPLIES_ANY_WAY.contains(key) && !p.hasKey("highway") && !p.hasKey("railway") && !p.hasKey("waterway")) {
+                addError(p, key, "highway/railway/waterway");
+            }
+        }
+    }
+
+    private void addError(OsmPrimitive p, String key1, String key2) {
+        errors.add(new TestError(this, Severity.WARNING,
+                tr("{0} is usually used with {1}", key1, key2),
+                2401, p));
+    }
+
+    @Override
+    public void visit(Node n) {
+        visit((OsmPrimitive) n);
+    }
+
+    @Override
+    public void visit(Way w) {
+        visit((OsmPrimitive) w);
+    }
+
+    @Override
+    public void visit(Relation r) {
+        visit((OsmPrimitive) r);
+    }
+}