Ticket #4011: ConfirmationDialog.patch

src/org/openstreetmap/josm/gui/ConditionalOptionPaneUtil.java

@@ -55 +55 @@
     }
 
     /**
+     * Returns the preference value for the preference key "message." + <code>prefKey</code> + ".value".
+     * The default value if the preference key is missing is -1.
+     *
+     * @param  the preference key
+     * @return prefKey the preference value for the preference key "message." + <code>prefKey</code> + ".value"
+     */
+    public static Integer getDialogReturnValue(String prefKey) {
+        return Main.pref.getInteger("message."+prefKey+".value", -1);
+    }
+
+    /**
+     * sets the value for the preference key "message." + <code>prefKey</code> + ".value".
+     *
+     * @param prefKey the key
+     * @param value the value
+     */
+    public static void setDialogReturnValue(String prefKey, Integer value) {
+        Main.pref.putInteger("message."+prefKey+".value", value);
+    }
+
+    /**
      * Displays an confirmation dialog with some option buttons given by <code>optionType</code>.
      * It is always on top even if there are other open windows like detached dialogs,
      * relation editors, history browsers and the like.
@@ -123 +144 @@
      * @see JOptionPane#ERROR_MESSAGE
      */
     static public boolean showConfirmationDialog(String preferenceKey, Component parent, Object message, String title, int optionType, int messageType, int trueOption) throws HeadlessException {
-        if (!getDialogShowingEnabled(preferenceKey))
-            return true;
+        if (!getDialogShowingEnabled(preferenceKey) && (getDialogReturnValue(preferenceKey) >= 0))
+            return getDialogReturnValue(preferenceKey) == trueOption;
         MessagePanel pnl = new MessagePanel(preferenceKey, message);
         int ret = JOptionPane.showConfirmDialog(parent, pnl, title, optionType, messageType);
-        pnl.remeberDialogShowingEnabled();
+        if ((ret >= 0) && !pnl.getDialogShowingEnabled()) {
+            setDialogShowingEnabled(preferenceKey, false);
+            setDialogReturnValue(preferenceKey, ret);
+        }
         return ret == trueOption;
     }
 
@@ -183 +207 @@
         }
 
         public boolean getDialogShowingEnabled() {
-            return cbShowDialog.isSelected();
+            return !cbShowDialog.isSelected();
         }
 
         public void remeberDialogShowingEnabled() {
-            ConditionalOptionPaneUtil.setDialogShowingEnabled(preferenceKey, !getDialogShowingEnabled());
+            ConditionalOptionPaneUtil.setDialogShowingEnabled(preferenceKey, getDialogShowingEnabled());
         }
     }
 }