Ticket #3696: optimize-selection-code.patch

(a) core/src/org/openstreetmap/josm/data/osm/DataSet.java~optimize-selection-code vs. (b) core-dave/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -145 +145 @@
         } else if (primitive instanceof Relation) {
             relations.remove(primitive);
         }
-        selectedPrimitves.remove(primitive);
+        selectedPrimitives.remove(primitive);
     }
 
     public Collection<OsmPrimitive> getSelectedNodesAndWays() {
-        Collection<OsmPrimitive> sel = getSelected(nodes);
-        sel.addAll(getSelected(ways));
+        Collection<OsmPrimitive> sel = new LinkedList<OsmPrimitive>();
+        for (OsmPrimitive osm : selectedPrimitives) {
+            if (osm instanceof Way ||
+                osm instanceof Node)
+                sel.add(osm);
+        }
         return sel;
     }
 
@@ -252 +256 @@
     }
 
     public void setSelected(Collection<? extends OsmPrimitive> selection) {
-        clearSelection(nodes);
-        clearSelection(ways);
-        clearSelection(relations);
-        addSelected(selection);
+        selectedPrimitives = new LinkedHashSet<OsmPrimitive>(selection);
         fireSelectionChanged(selection);
     }
 
@@ -266 +267 @@
         }
         List<OsmPrimitive> list = Arrays.asList(osm);
         setSelected(list);
-        fireSelectionChanged(Arrays.asList(osm));
+        fireSelectionChanged(list);
     }
 
     /**
@@ -312 +313 @@
     private Collection<OsmPrimitive> getSelected(Collection<? extends OsmPrimitive> list) {
         if (list == null)
             return new LinkedList<OsmPrimitive>();
+        // getSelected() is called with large lists, so
+        // creating the return list from the selection
+        // should be faster most of the time.
         Collection<OsmPrimitive> sel = new LinkedHashSet<OsmPrimitive>(selectedPrimitives);
         sel.retainAll(list);
         return sel;