Ticket #24979: Patch-Refactoring-of-DisplayPreferenceTest.patch

test/unit/org/openstreetmap/josm/gui/preferences/display/DisplayPreferenceTest.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.gui.preferences.display;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
+import org.openstreetmap.josm.gui.preferences.PreferenceSetting;
 import org.openstreetmap.josm.gui.preferences.PreferencesTestUtils;
 
 /**
  * Unit tests of {@link DisplayPreference} class.
  */
+@Execution(ExecutionMode.SAME_THREAD)
 class DisplayPreferenceTest {
+    
     /**
      * Unit test of {@link DisplayPreference#DisplayPreference}.
      */
     @Test
-    void testDisplayPreference() {
-        assertNotNull(new DisplayPreference.Factory().createPreferenceSetting());
+    void testDisplayPreference_ShouldCreateValidInstance() {
+        final PreferenceSetting preferenceSetting = new DisplayPreference.Factory().createPreferenceSetting();
+        
+        assertNotNull(preferenceSetting, () -> "The factory should not return null.");
+        assertInstanceOf(DisplayPreference.class, preferenceSetting, 
+                () -> "The factory should create a valid DisplayPreference instance.");
     }
 
     /**
-     * Unit test of {@link DisplayPreference#addGui}.
+     * Smoke test for {@link DisplayPreference#addGui} without verifying tab integration.
      */
     @Test
-    void testAddGui() {
-        PreferencesTestUtils.doTestPreferenceSettingAddGui(new DisplayPreference.Factory(), null);
+    void testAddGui_WithoutParentClass_ShouldNotThrowException() {
+        assertDoesNotThrow(() -> 
+        PreferencesTestUtils.doTestPreferenceSettingAddGui(new DisplayPreference.Factory(), null),
+        "Should not throw an exception when parent class is null (e.g. when menu is invisible or not registered).");
     }
 }