Ticket #21906: 21906.patch

plugins/http2/src/org/openstreetmap/josm/plugins/http2/Http2Client.java

@@ -36 +36 @@
 public final class Http2Client extends org.openstreetmap.josm.tools.HttpClient {
 
     private static final Map<Duration, HttpClient> clientForConnectTimeout = new ConcurrentHashMap<>();
+    private static final String USER_AGENT_STRING = "User-Agent";
     private HttpRequest request;
     private HttpResponse<InputStream> response;
 
@@ -56 +57 @@
 
     HttpRequest createRequest() throws IOException {
         HttpRequest.Builder requestBuilder;
+        Map<String, String> headers = getHeaders();
         try {
             requestBuilder = HttpRequest.newBuilder()
                       .uri(getURL().toURI())
                       .method(getRequestMethod(), hasRequestBody()
                               ? BodyPublishers.ofByteArray(getRequestBody())
                               : BodyPublishers.noBody())
-                      .header("User-Agent", Version.getInstance().getFullAgentString());
+                      .header(USER_AGENT_STRING, headers.getOrDefault(USER_AGENT_STRING, Version.getInstance().getFullAgentString()));
         } catch (URISyntaxException e) {
             throw new IOException(e);
         }
@@ -77 +79 @@
         if (!isUseCache()) {
             requestBuilder.header("Cache-Control", "no-cache");
         }
-        for (Map.Entry<String, String> header : getHeaders().entrySet()) {
-            if (header.getValue() != null) {
+        for (Map.Entry<String, String> header : headers.entrySet()) {
+            if (header.getValue() != null && !USER_AGENT_STRING.equals(header.getKey())) {
                 try {
                     requestBuilder.header(header.getKey(), header.getValue());
                 } catch (IllegalArgumentException e) {

plugins/http2/src/org/openstreetmap/josm/plugins/http2/Http2Plugin.java

@@ -3 +3 @@
 
 import org.openstreetmap.josm.plugins.Plugin;
 import org.openstreetmap.josm.plugins.PluginInformation;
+import org.openstreetmap.josm.tools.Destroyable;
+import org.openstreetmap.josm.tools.Http1Client;
 import org.openstreetmap.josm.tools.HttpClient;
 
 /**
  * Provides HTTP/2 support.
  */
-public class Http2Plugin extends Plugin {
+public class Http2Plugin extends Plugin implements Destroyable {
 
     /**
      * Constructs a new {@code Http2Plugin}.
@@ -18 +20 @@
         super(info);
         HttpClient.setFactory(Http2Client::new);
     }
+
+    @Override
+    public void destroy() {
+        HttpClient.setFactory(Http1Client::new);
+    }
 }