Ticket #21901: 21901.patch

src/org/openstreetmap/josm/gui/MapMover.java

@@ -185 +185 @@
         if (allowMovement) {
             doMoveForDrag(e);
         } else {
-            endMovement();
+            endMovement(e);
         }
     }
 
@@ -195 +195 @@
         }
         EastNorth center = nc.getCenter();
         EastNorth mouseCenter = nc.getEastNorth(e.getX(), e.getY());
-        nc.zoomTo(mousePosMoveStart.getEastNorth().add(center).subtract(mouseCenter));
+        nc.zoomTo(e, mousePosMoveStart.getEastNorth().add(center).subtract(mouseCenter));
     }
 
     /**
@@ -217 +217 @@
     @Override
     public void mouseReleased(MouseEvent e) {
         if (e.getButton() == MouseEvent.BUTTON3 || (PlatformManager.isPlatformOsx() && e.getButton() == MouseEvent.BUTTON1)) {
-            endMovement();
+            endMovement(e);
         }
     }
 
@@ -237 +237 @@
     /**
      * End the movement. Setting back the cursor and clear the movement variables
      */
-    private void endMovement() {
+    private void endMovement(MouseEvent e) {
         if (!movementInProgress()) {
             return;
         }
+        doMoveForDrag(e);
         nc.resetCursor(this);
         mousePosMoveStart = null;
         MainApplication.getLayerManager().getLayers().forEach(Layer::invalidate);
@@ -270 +271 @@
             if (e.getModifiersEx() == MouseEvent.CTRL_DOWN_MASK) {
                 doMoveForDrag(e);
             } else {
-                endMovement();
+                endMovement(e);
             }
         }
     }

src/org/openstreetmap/josm/gui/NavigatableComponent.java

@@ -8 +8 @@
 import java.awt.event.ComponentEvent;
 import java.awt.event.HierarchyEvent;
 import java.awt.event.HierarchyListener;
+import java.awt.event.InputEvent;
+import java.awt.event.MouseEvent;
 import java.awt.geom.AffineTransform;
 import java.awt.geom.Point2D;
 import java.nio.charset.StandardCharsets;
@@ -77 +79 @@
 
     /**
      * Interface to notify listeners of the change of the zoom area.
+     * If you need to not paint during panning, override {@link #zoomChanged(InputEvent)}.
      * @since 10600 (functional interface)
      */
     @FunctionalInterface
@@ -85 +88 @@
          * Method called when the zoom area has changed.
          */
         void zoomChanged();
+
+        /**
+         * Method called when the zoom area has changed.
+         * @param event The originating input event. May be {@code null}.
+         * @since xxx
+         */
+        default void zoomChanged(InputEvent event) {
+            zoomChanged();
+        }
     }
 
     /**
@@ -141 +153 @@
         }
     }
 
+    /**
+     * Fire zoom changed events. Kept for backwards compatibility.
+     * @deprecated Since xxx, use {@link #fireZoomChanged(InputEvent)} instead ({@code null} safe)
+     */
+    @Deprecated
     protected static void fireZoomChanged() {
+
+    }
+
+    protected static void fireZoomChanged(InputEvent originatingEvent) {
         GuiHelper.runInEDTAndWait(() -> {
             for (ZoomChangeListener l : zoomChangeListeners) {
-                l.zoomChanged();
+                l.zoomChanged(originatingEvent);
             }
         });
+        // Just in case someone, somewhere, decided to subclass this and override fireZoomChanged.
+        fireZoomChanged();
     }
 
     // The only events that may move/resize this map view are window movements or changes to the map view size.
@@ -617 +640 @@
      * @param initial true if this call initializes the viewport.
      */
     public void zoomTo(EastNorth center, double scale, boolean initial) {
+        zoomTo(null, center, scale, initial);
+    }
+
+    /**
+     * Zoom to the given coordinate and scale.
+     *
+     * @param e The originating input event
+     * @param center The center x-value (easting) to zoom to.
+     * @param scale The scale to use.
+     * @param initial true if this call initializes the viewport.
+     */
+    void zoomTo(InputEvent e, EastNorth center, double scale, boolean initial) {
         Bounds b = getProjection().getWorldBoundsLatLon();
         ProjectionBounds pb = getProjection().getWorldBoundsBoxEastNorth();
         double newScale = scale;
@@ -682 +717 @@
         newCenter = newCenter.subtract(enShift);
 
         EastNorth oldCenter = getCenter();
-        if (!newCenter.equals(oldCenter) || !Utils.equalsEpsilon(getScale(), newScale)) {
+        if (!newCenter.equals(oldCenter) || !Utils.equalsEpsilon(getScale(), newScale)
+                || (e != null && e.getID() == MouseEvent.MOUSE_RELEASED)) {
             if (!initial) {
                 pushZoomUndo(oldCenter, getScale());
             }
-            zoomNoUndoTo(newCenter, newScale, initial);
+            zoomNoUndoTo(e, newCenter, newScale, initial);
         }
     }
 
     /**
      * Zoom to the given coordinate without adding to the zoom undo buffer.
      *
+     * @param originatingEvent The originating input event
      * @param newCenter The center x-value (easting) to zoom to.
      * @param newScale The scale to use.
      * @param initial true if this call initializes the viewport.
      */
-    private void zoomNoUndoTo(EastNorth newCenter, double newScale, boolean initial) {
+    private void zoomNoUndoTo(InputEvent originatingEvent, EastNorth newCenter, double newScale, boolean initial) {
         if (!Utils.equalsEpsilon(getScale(), newScale)) {
             state = state.usingScale(newScale);
         }
@@ -706 +743 @@
         }
         if (!initial) {
             repaint();
-            fireZoomChanged();
+            fireZoomChanged(originatingEvent);
         }
     }
 
@@ -718 +755 @@
         zoomTo(newCenter, getScale());
     }
 
+    /**
+     * Zoom to given east/north.
+     * @param e The originating input event
+     * @param newCenter new center coordinates
+     */
+    void zoomTo(InputEvent e, EastNorth newCenter) {
+        zoomTo(e, newCenter, getScale(), false);
+    }
+
     /**
      * Zoom to given lat/lon.
      * @param newCenter new center coordinates
@@ -943 +989 @@
         if (!zoomUndoBuffer.isEmpty()) {
             ZoomData zoom = zoomUndoBuffer.pop();
             zoomRedoBuffer.push(new ZoomData(getCenter(), getScale()));
-            zoomNoUndoTo(zoom.getCenterEastNorth(), zoom.getScale(), false);
+            zoomNoUndoTo(null, zoom.getCenterEastNorth(), zoom.getScale(), false);
         }
     }
 
@@ -954 +1000 @@
         if (!zoomRedoBuffer.isEmpty()) {
             ZoomData zoom = zoomRedoBuffer.pop();
             zoomUndoBuffer.push(new ZoomData(getCenter(), getScale()));
-            zoomNoUndoTo(zoom.getCenterEastNorth(), zoom.getScale(), false);
+            zoomNoUndoTo(null, zoom.getCenterEastNorth(), zoom.getScale(), false);
         }
     }
 

src/org/openstreetmap/josm/gui/autofilter/AutoFilterManager.java

@@ -4 +4 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
 import java.awt.Graphics2D;
+import java.awt.event.InputEvent;
+import java.awt.event.MouseEvent;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
@@ -127 +129 @@
         registerAutoFilterRules(AutoFilterRule.defaultRules());
     }
 
-    private synchronized void updateButtons() {
+    private void updateButtons() {
+        updateButtons(null);
+    }
+
+    private synchronized void updateButtons(InputEvent inputEvent) {
+        // Don't update while dragging
+        if (inputEvent != null && inputEvent instanceof MouseEvent &&
+                ((MouseEvent) inputEvent).getID() == MouseEvent.MOUSE_DRAGGED) {
+            return;
+        }
         MapFrame map = MainApplication.getMap();
         if (enabledRule != null && map != null
                 && enabledRule.getMinZoomLevel() <= Selector.GeneralSelector.scale2level(map.mapView.getDist100Pixel())) {
@@ -261 +272 @@
 
     @Override
     public void zoomChanged() {
-        updateButtons();
+        this.zoomChanged(null);
+    }
+
+    @Override
+    public void zoomChanged(InputEvent event) {
+        updateButtons(event);
     }
 
     @Override