Ticket #21740: 21740-MainLayerManagerTest.patch

test/unit/org/openstreetmap/josm/gui/layer/MainLayerManagerTest.java

@@ -2 +2 @@
 package org.openstreetmap.josm.gui.layer;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.List;
+import java.util.logging.Handler;
+import java.util.logging.LogRecord;
 
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.BeforeEach;
@@ -55 +59 @@
         }
     }
 
+    protected static class LoggingHandler extends Handler {
+
+        private List<LogRecord> records = new ArrayList<>();
+
+        @Override
+        public void publish(LogRecord record) {
+            records.add(record);
+        }
+
+        @Override
+        public void flush() {}
+
+        @Override
+        public void close() throws SecurityException {}
+
+        public List<LogRecord> getRecords() {
+            return records;
+        }
+
+    }
+
     @BeforeAll
     public static void setUpClass() {
         JOSMFixture.createUnitTestFixture().init();
@@ -145 +170 @@
     @Test
     void testAddActiveLayerChangeListenerTwice() {
         CapturingActiveLayerChangeListener listener = new CapturingActiveLayerChangeListener();
+        LoggingHandler handler = new LoggingHandler();
+        Logging.getLogger().addHandler(handler);
+
         layerManagerWithActive.addActiveLayerChangeListener(listener);
-        Logging.clearLastErrorAndWarnings();
+        assertTrue(handler.getRecords().isEmpty());
+
         layerManagerWithActive.addActiveLayerChangeListener(listener);
-        assertFalse(Logging.getLastErrorAndWarnings().isEmpty());
+        assertTrue(handler.getRecords().get(1).getMessage().startsWith("Attempted to add listener that was already in list"));
+
+        Logging.getLogger().removeHandler(handler);
     }
 
     /**
@@ -174 +205 @@
      */
     @Test
     void testRemoveActiveLayerChangeListenerNotInList() {
-        Logging.clearLastErrorAndWarnings();
+        LoggingHandler handler = new LoggingHandler();
+        Logging.getLogger().addHandler(handler);
+
         layerManagerWithActive.removeActiveLayerChangeListener(new CapturingActiveLayerChangeListener());
-        assertFalse(Logging.getLastErrorAndWarnings().isEmpty());
+        assertTrue(handler.getRecords().get(1).getMessage().startsWith("Attempted to remove listener that was not in list"));
+
+        Logging.getLogger().removeHandler(handler);
     }
 
     /**