Ticket #20902: josm_combinations_only_tag_v4.patch

resources/data/validator/combinations.mapcss

@@ -6 +6 @@
   set unpaved_surface;
 }
 
+node[eval(number_of_tags()) = 1],
+way[eval(number_of_tags()) = 1],
+relation[type][eval(number_of_tags()) = 2] {
+  set one_tag;
+}
+
 /* {0.key} without {1.key} (warning level) */
 way[junction                   ][!highway][junction!=yes][!area:highway],
 way[living_street              ][!highway],
@@ -337 +343 @@
 }
 
 /* #16214 */
-relation[type=multipolygon] >[role="inner"] way[area][eval(number_of_tags()) = 1] {
+relation[type=multipolygon] >[role="inner"] way[area].one_tag {
   throwWarning: tr("{0} on an inner multipolygon ring without further tags", "{0.tag}");
   fixRemove: "area";
   set area_yes_autofix;
   group: tr("suspicious tag combination");
 }
 
-/* only {0.key}, #11104, #12422, #14950, #19572 */
-*[lanes][eval(number_of_tags()) = 1],
-*[surface][eval(number_of_tags()) = 1],
-*[access][eval(number_of_tags()) = 1],
-*[area][eval(number_of_tags()) = 1]!.area_yes_autofix,
-*[name][eval(number_of_tags()) = 1],
-*[ref][eval(number_of_tags()) = 1],
-*[lit][eval(number_of_tags()) = 1] {
+/* only {0.key}, #11104, #12422, #14950, #19572, #20902 */
+/* multipolygon has own test for most cases, see #20909 */
+/* boundary, connectivity, enforcement, restriction, route and waterway have own test for needed subkeys */
+*[access].one_tag[type !~ /^(boundary|connectivity|enforcement|multipolygon|restriction|route|waterway)$/],
+*[area].one_tag!.area_yes_autofix[type !~ /^(boundary|connectivity|enforcement|multipolygon|restriction|route|waterway)$/],
+*[lanes].one_tag[type !~ /^(boundary|connectivity|enforcement|multipolygon|restriction|route|waterway)$/],
+*[layer].one_tag[type !~ /^(boundary|bridge|building|connectivity|enforcement|multipolygon|restriction|route|tunnel|waterway)$/], /* some relations are valid */
+way[level].one_tag, /* nodes might be valid */
+relation[level].one_tag[type !~ /^(boundary|connectivity|enforcement|multipolygon|restriction|route|waterway)$/],
+*[lit].one_tag[type !~ /^(boundary|connectivity|enforcement|multipolygon|restriction|route|waterway)$/],
+*[name].one_tag[type !~ /^(associatedStreet|boundary|bridge|building|connectivity|enforcement|multipolygon|restriction|route|site|street|tunnel|waterway)$/], /* most relations are valid */
+*[ref].one_tag[type !~ /^(boundary|connectivity|enforcement|multipolygon|restriction|route|waterway)$/],
+*[surface].one_tag[type !~ /^(boundary|connectivity|enforcement|restriction|route|waterway)$/] {
   throwWarning: tr("incomplete object: only {0}", "{0.key}");
   set only_one_tag;
   group: tr("missing tag");
@@ -363 +374 @@
   group: tr("missing tag");
 }
 /* only {0.tag}, #15269 */
-*[tourism=attraction][eval(number_of_tags()) = 1] {
+*[tourism=attraction].one_tag {
   throwWarning: tr("incomplete object: only {0}", "{0.tag}");
   group: tr("missing tag");
 }