Ticket #20455: 20455.patch

File 20455.patch, 1.2 KB (added by GerdP, 5 years ago)

Raise warning to error for all checks when we know that the tag must describe an area

  • src/org/openstreetmap/josm/data/validation/tests/UnclosedWays.java

     
    9595        public final TestError getTestError(Way w, UnclosedWays test) {
    9696            String value = w.get(key);
    9797            if (isValueErroneous(value)) {
    98                 return TestError.builder(test, Severity.WARNING, code)
     98                final Severity severity;
     99                // see #20455: raise severity to error when we are sure that tag key must describe an area
     100                if (ignore && !specialValues.isEmpty()) {
     101                    severity = Severity.WARNING;
     102                } else {
     103                    severity = Severity.ERROR;
     104                }
     105                return TestError.builder(test, severity, code)
    99106                        .message(tr("Unclosed way"), engMessage, engMessage.contains("{0}") ? new Object[]{value} : new Object[]{})
    100107                        .primitives(w)
    101108                        .highlight(Arrays.asList(w.firstNode(), w.lastNode()))