Ticket #19876: 19876.patch

src/org/openstreetmap/josm/gui/preferences/PreferenceDialog.java

@@ -229 +229 @@
     public void dispose() {
         previouslySelected = tpPreferences.getSelectedTab();
         removeWindowListener(windowEventHandler);
+        setVisible(false); // save current geometry
         super.dispose();
     }
 }

src/org/openstreetmap/josm/gui/preferences/PreferenceTabbedPane.java

@@ -642 +642 @@
                     Icon icon = getIconAt(index);
                     remove(index);
                     if (index <= insertGUITabsForSetting(icon, preferenceSettings, index)) {
+                        if (index > 0) {
+                            // see #19876: avoid situation when icon in left pane doesn't match the preference setting
+                            setSelectedIndex(0);
+                        }
                         setSelectedIndex(index);
                     }
                 } catch (SecurityException ex) {