Ticket #19865: fix_ioobe_remove_image.patch

src/org/openstreetmap/josm/data/ImageData.java

@@ -266 +266 @@
         for (ImageEntry img: getSelectedImages()) {
             data.remove(img);
         }
-        if (selectedImagesIndex.get(0) == data.size()) {
+        if (selectedImagesIndex.get(0) >= data.size()) {
             setSelectedImageIndex(data.size() - 1);
         } else {
             setSelectedImageIndex(selectedImagesIndex.get(0), true);

test/unit/org/openstreetmap/josm/data/ImageDataTest.java

@@ -195 +195 @@
     }
 
     @Test
+    public void testRemoveSelectedImagesWithRemainingImages() {
+        List<ImageEntry> list = getOneImage();
+        list.add(new ImageEntry());
+        list.add(new ImageEntry());
+
+        ImageData data = new ImageData(list);
+        data.selectLastImage();
+        data.addImageToSelection(list.get(1));
+        data.removeSelectedImages();
+        assertEquals(1, data.getImages().size());
+        assertEquals(1, data.getSelectedImages().size());
+    }
+
+    @Test
     public void testSelectImageAfterRemove() {
         List<ImageEntry> list = getOneImage();
         list.add(new ImageEntry());
@@ -346 +360 @@
         assertEquals(0, data.getSelectedImages().size());
         data.selectFirstImage();
         assertEquals(1, data.getSelectedImages().size());
-
     }
 
     @Test