Ticket #19508: 19508v1.patch

src/org/openstreetmap/josm/actions/corrector/ReverseWayTagCorrector.java

@@ -206 +206 @@
      * @return opposite numeric value
      */
     public static String invertNumber(String value) {
-        Pattern pattern = Pattern.compile("^([+-]?)(\\d.*)$", Pattern.CASE_INSENSITIVE);
+        Pattern pattern = Pattern.compile("^([+-]?)(\\d*[,.]?\\d*)(.*)$", Pattern.CASE_INSENSITIVE);
         Matcher matcher = pattern.matcher(value);
         if (!matcher.matches()) return value;
         String sign = matcher.group(1);
-        String rest = matcher.group(2);
+        String number = matcher.group(2);
+        String symbol = matcher.group(3);
         sign = "-".equals(sign) ? "" : "-";
-        return sign + rest;
+
+        if (!number.isEmpty()) {
+            String fixedNum = number.replace(",", ".");
+            double parsed = Double.parseDouble(sign + fixedNum);
+            if (parsed > 0 || parsed < 0) {
+                return sign + number + symbol;
+            }
+        }
+
+        return value;
     }
 
     static List<TagCorrection> getTagCorrections(Tagged way) {

test/unit/org/openstreetmap/josm/actions/corrector/ReverseWayTagCorrectorTest.java

@@ -96 +96 @@
         assertSwitch(new Tag("something", "prefix_down_suffix"), new Tag("something", "prefix_up_suffix"));
         // #8499
         assertSwitch(new Tag("type", "drawdown"), new Tag("type", "drawdown"));
+        // #19508
+        assertSwitch(new Tag("incline", "0%"), new Tag("incline", "0%"));
+        assertSwitch(new Tag("incline", "-10%"), new Tag("incline", "10%"));
+        assertSwitch(new Tag("incline", "0.6°"), new Tag("incline", "-0.6°"));
+        assertSwitch(new Tag("incline", "-10,33°"), new Tag("incline", "10,33°"));
     }
 
     private void assertSwitch(Tag oldTag, Tag newTag) {
-        Assert.assertEquals(ReverseWayTagCorrector.TagSwitcher.apply(oldTag), newTag);
+        Assert.assertEquals(newTag, ReverseWayTagCorrector.TagSwitcher.apply(oldTag));
     }
 
     private Map<OsmPrimitive, List<TagCorrection>> getTagCorrectionsForWay(String middleNodeTags) {