Ticket #1937: look ma, no modes!.patch

src/org/openstreetmap/josm/actions/mapmode/DrawAction.java

@@ -33 +33 @@
 import javax.swing.JOptionPane;
 
 import org.openstreetmap.josm.Main;
-import org.openstreetmap.josm.actions.mapmode.SelectAction;
 import org.openstreetmap.josm.command.AddCommand;
 import org.openstreetmap.josm.command.ChangeCommand;
 import org.openstreetmap.josm.command.Command;
@@ -48 +47 @@
 import org.openstreetmap.josm.data.osm.WaySegment;
 import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.gui.MapView;
+import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.MapViewPaintable;
-import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Pair;
@@ -68 +67 @@
     private boolean shift;
     private boolean mouseOnExistingNode;
     private boolean drawHelperLine;
+    private boolean wayIsFinished = false;
     private Point mousePos;
     private Color selectedColor;
 
@@ -96 +96 @@
         super.enterMode();
         selectedColor = Main.pref.getColor(marktr("selected"), Color.red);
         drawHelperLine = Main.pref.getBoolean("draw.helper-line", true);
-
+        wayIsFinished = false;
+        
         Main.map.mapView.addMouseListener(this);
         Main.map.mapView.addMouseMotionListener(this);
         Main.map.mapView.addTemporaryLayer(this);
@@ -160 +161 @@
         if(e.getClickCount() > 1) {
             // A double click equals "user clicked last node again, finish way"
             lastUsedNode = null;
+            wayIsFinished = true;
+            Main.map.selectSelectTool(true);
             return;
         }
         // we copy ctrl/alt/shift from the event just in case our global
@@ -177 +180 @@
             replacedWays = new ArrayList<Way>();
         boolean newNode = false;
         Node n = null;
-        boolean wayIsFinished = false;
 
         if (!ctrl)
             n = Main.map.mapView.getNearestNode(mousePos);
@@ -251 +253 @@
 
         // If the above does not apply, the selection is cleared and a new try is started
         boolean extendedWay = false;
-        if (!shift && selection.size() > 0) {
+        boolean wayIsFinishedTemp = wayIsFinished;
+        wayIsFinished = false;
+        if (!shift && selection.size() > 0 && !wayIsFinishedTemp) {
             Node selectedNode = null;
             Way selectedWay = null;
             
@@ -325 +329 @@
             // User clicked last node again, finish way
             if(n0 == n) {
                 lastUsedNode = null;
+                wayIsFinished = true;
+                Main.map.selectSelectTool(true);
                 return;
             }
 
@@ -372 +378 @@
             extendedWay = true;
             Main.ds.setSelected(way);
         }
-                
+      
         String title;
         if (!extendedWay) {
             if (!newNode) {
@@ -504 +510 @@
         Main.map.statusLine.setDist(distance);
         updateStatusLine();
 
-        if (!drawHelperLine) return;
+        if (!drawHelperLine || wayIsFinished) return;
 
         Main.map.mapView.repaint();
     }

src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -18 +18 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.MergeNodesAction;
 import org.openstreetmap.josm.command.AddCommand;
+import org.openstreetmap.josm.command.ChangeCommand;
 import org.openstreetmap.josm.command.Command;
-import org.openstreetmap.josm.command.ChangeCommand;
 import org.openstreetmap.josm.command.MoveCommand;
 import org.openstreetmap.josm.command.RotateCommand;
 import org.openstreetmap.josm.command.SequenceCommand;
@@ -31 +31 @@
 import org.openstreetmap.josm.data.osm.WaySegment;
 import org.openstreetmap.josm.data.osm.visitor.AllNodesVisitor;
 import org.openstreetmap.josm.data.osm.visitor.SimplePaintVisitor;
-import org.openstreetmap.josm.gui.layer.Layer;
-import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.gui.MapView;
 import org.openstreetmap.josm.gui.SelectionManager;
 import org.openstreetmap.josm.gui.SelectionManager.SelectionEnded;
+import org.openstreetmap.josm.gui.layer.Layer;
+import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.tools.ImageProvider;
 import org.openstreetmap.josm.tools.Shortcut;
 
@@ -328 +328 @@
     @Override public void mouseReleased(MouseEvent e) {
         if (mode == Mode.select) {
             selectionManager.unregister(Main.map.mapView);
+            if(Main.ds.getSelected().size() == 0)
+                Main.map.selectDrawTool(true);
+                return;
         }
         restoreCursor();
 

src/org/openstreetmap/josm/gui/MapFrame.java

@@ -111 +111 @@
         // status line below the map
         statusLine = new MapStatus(this);
     }
+    
+    public void selectSelectTool(boolean onlyIfModeless) {
+        if(onlyIfModeless && !Main.pref.getBoolean("modeless", false))
+            return;
+        
+        selectMapMode((MapMode)getDefaultButtonAction());
+    }
+    
+    public void selectDrawTool(boolean onlyIfModeless) {
+        if(onlyIfModeless && !Main.pref.getBoolean("modeless", false))
+            return;
+        
+        Action drawAction = ((AbstractButton)toolBarActions.getComponent(1)).getAction();
+        selectMapMode((MapMode)drawAction);
+    }
 
     /**
      * Called as some kind of destructor when the last layer has been removed.