Ticket #17041: 16041-overlapping-ways.patch

src/org/openstreetmap/josm/data/validation/tests/OverlappingWays.java

@@ -193 +193 @@
                 duplicateWaySegments.add(segment);
             }
         }
-        if (duplicateWaySegments.size() > 1) {
-            return duplicateWaySegments;
-        } else {
-            return null;
-        }
+        return duplicateWaySegments;
     }
 
     @Override
@@ -204 +200 @@
     public void visit(Way w) {
 
         final Set<WaySegment> duplicateWaySegment = checkDuplicateWaySegment(w);
-        if (duplicateWaySegment != null) {
+        if (!duplicateWaySegment.isEmpty()) {
             errors.add(TestError.builder(this, Severity.ERROR, DUPLICATE_WAY_SEGMENT)
                     .message(tr("Way contains segment twice"))
                     .primitives(w)