Ticket #16898: josm_16898_v4.patch

resources/data/validator/combinations.mapcss

@@ -142 +142 @@
 *[office=government][!government],
 *[power=generator][!generator:source],
 *[amenity=social_facility][!social_facility],
-*[amenity=place_of_worship][!religion] {
+*[amenity=place_of_worship][!religion],
+*[man_made=tower][!tower:type] {
   throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
   group: tr("missing tag");
 }
@@ -728 +729 @@
 *[source:maxspeed][!/^maxspeed:?/] {
   throwWarning: tr("{0} without {1} or {2}", "{0.key}", "maxspeed", "maxspeed:*");
   group: tr("missing tag");
-}
- No newline at end of file
+}
+
+/* tower vs. communications_tower, #16898 */
+*[man_made=communications_tower][height =~ /^((7[0-4]|[1-6]?[0-9])(\.[0-9]*)?( m)?|(2(4[0-5]|[0-3][0-9])|1?[0-9]?[0-9])((\.[0-9]*)?( ft|\')|\'(11|10|[0-9])(\.[0-9]*)?\"))$/] { /* 75m ~ 246ft ~ 246' */
+  throwWarning: tr("{0} and {1} below 75m is uncommon. Maybe, {2} together with {3} is a better choice", "{0.tag}", "{1.key}", "man_made=tower", "tower:type=communication");
+  group: tr("suspicious tag combination");
+  assertMatch: "relation man_made=communications_tower height=58";
+  assertMatch: "node man_made=communications_tower height=\"74 m\"";
+  assertMatch: "node man_made=communications_tower height=0.8";
+  assertMatch: "relation man_made=communications_tower height=245'";
+  assertMatch: "way man_made=communications_tower height=\"224.22 ft\"";
+  assertMatch: "way man_made=communications_tower height=231'10.22\"";
+  assertNoMatch: "node man_made=communications_tower height=\"75 m\"";
+  assertNoMatch: "node man_made=communications_tower height=75.72";
+  assertNoMatch: "way man_made=communications_tower height=\"328.22 ft\"";
+  assertNoMatch: "relation man_made=communications_tower height=4358'8\"";
+  assertNoMatch: "relation height=4358'";
+}