Ticket #16898: josm_16898_v3.patch

src/org/openstreetmap/josm/resources/data/validator/combinations.mapcss

@@ -123 +123 @@
   group: tr("missing tag");
 }
 
-/* {0.tag} without {1.key} (warning level), #18411, #18246 */
+/* {0.tag} without {1.key} (warning level), #18411, #18246, #16898 */
 way[railway=construction][!construction],
 way[highway=construction][!construction],
 node[traffic_sign=maxspeed][!maxspeed],
@@ -143 +143 @@
 *[office=government][!government],
 *[power=generator][!generator:source],
 *[amenity=social_facility][!social_facility],
-*[amenity=place_of_worship][!religion] {
+*[amenity=place_of_worship][!religion],
+*[man_made=tower][!tower:type] {
   throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
   group: tr("missing tag");
 }
@@ -694 +695 @@
   throwWarning: tr("{0} without {1} or {2}", "{0.key}", "maxspeed", "maxspeed:*");
   group: tr("missing tag");
 }
+ No newline at end of file
+
+/* tower vs. communications_tower, #16898 */
+*[man_made=tower][tower:type=communication][material=concrete][height =~ /^([1-9][0-9][0-9][0-9]*(\.[0-9]*)?( m)?|([1-9][0-9][0-9][0-9]+|[4-9][0-9][0-9]|3([3-9][0-9]|2[89]))((\.[0-9]*)?( ft|\')|\'(11|10|[0-9])(\.[0-9]*)?\"))$/] { /* 100m ~ 328 ft ~ 328' TODO "'" */
+  throwWarning: tr("{0} together with {1}, {2} and {3} equal or greater 100. Consider using man_made=communications_tower instead", "{0.tag}", "{1.tag}", "{2.tag}", "{3.key}");
+  group: tr("suspicious tag combination");
+  assertMatch: "node man_made=tower tower:type=communication material=concrete height=\"100 m\"";
+  assertMatch: "node man_made=tower tower:type=communication material=concrete height=100.72";
+  assertMatch: "way man_made=tower tower:type=communication material=concrete height=\"328.22 ft\"";
+  assertMatch: "relation man_made=tower tower:type=communication material=concrete height=2358'8\"";
+  assertNoMatch: "node man_made=tower tower:type=communication material=concrete height=\"99 m\"";
+  assertNoMatch: "node man_made=tower tower:type=communication material=concrete height=0.8";
+  assertNoMatch: "way man_made=tower tower:type=communication material=concrete height=\"324.22 ft\"";
+  assertNoMatch: "relation man_made=tower material=concrete height=358'";
+}
+*[man_made=communications_tower][height =~ /^([1-9]?[0-9](\.[0-9]*)?( m)?|([12]?[0-9]?[0-9]|31[0-9]|32[0-7])((\.[0-9]*)?( ft|\')|\'(11|10|[0-9])(\.[0-9]*)?\"))$/] {
+  throwWarning: tr("{0} and {1} below 100. Consider using man_made=tower with tower:type=communication instead", "{0.tag}", "{1.key}");
+  group: tr("suspicious tag combination");
+  assertMatch: "relation man_made=communications_tower height=58";
+  assertMatch: "node man_made=communications_tower height=\"99 m\"";
+  assertMatch: "node man_made=communications_tower height=0.8";
+  assertMatch: "relation man_made=communications_tower height=326'";
+  assertMatch: "way man_made=communications_tower height=\"224.22 ft\"";
+  assertMatch: "way man_made=communications_tower height=317'10.22\"";
+  assertNoMatch: "node man_made=communications_tower height=\"100 m\"";
+  assertNoMatch: "node man_made=communications_tower height=100.72";
+  assertNoMatch: "way man_made=communications_tower height=\"328.22 ft\"";
+  assertNoMatch: "relation man_made=communications_tower height=4358'8\"";
+  assertNoMatch: "relation height=4358'";