Ticket #11686: 11686.patch

src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetTagsPanel.java

@@ -25 +25 @@
         setLayout(new BorderLayout());
         setBorder(BorderFactory.createEmptyBorder(5, 5, 5, 5));
         model = new TagEditorModel();
-        TagTable tblTags = new TagTable(model);
+        TagTable tblTags = new TagTable(model, 0);
         tblTags.setEnabled(false);
         add(new JScrollPane(tblTags), BorderLayout.CENTER);
     }

src/org/openstreetmap/josm/gui/io/TagSettingsPanel.java

@@ -21 +21 @@
 public class TagSettingsPanel extends JPanel implements TableModelListener {
 
     /** checkbox for selecting whether an atomic upload is to be used  */
-    private final TagEditorPanel pnlTagEditor = new TagEditorPanel(null);
+    private final TagEditorPanel pnlTagEditor = new TagEditorPanel(null, null, Changeset.MAX_CHANGESET_TAG_LENGTH);
     /** the model for the changeset comment */
     private final transient ChangesetCommentModel changesetCommentModel;
     private final transient ChangesetCommentModel changesetSourceModel;

src/org/openstreetmap/josm/gui/tagging/TagCellEditor.java

@@ -29 +29 @@
 
     /**
      * constructor
+     * @param maxCharacters maximum number of characters allowed, 0 for unlimited
      */
-    public TagCellEditor() {
+    public TagCellEditor(int maxCharacters) {
         editor = new AutoCompletingTextField(0, false);
+        if (maxCharacters > 0) {
+            editor.setMaxChars(maxCharacters);
+        }
         editor.setBorder(BorderFactory.createEmptyBorder(1, 1, 1, 1));
     }
 

src/org/openstreetmap/josm/gui/tagging/TagEditorPanel.java

@@ -35 +35 @@
     /** the tag editor model */
     private TagEditorModel model;
     /** the tag table */
-    private TagTable tagTable;
+    private final TagTable tagTable;
 
     private PresetListPanel presetListPanel;
     private final transient PresetHandler presetHandler;
@@ -47 +47 @@
      */
     protected JPanel buildTagTableEditorPanel() {
         JPanel pnl = new JPanel();
-        tagTable = new TagTable(model);
         pnl.setLayout(new BorderLayout());
         pnl.add(new JScrollPane(tagTable), BorderLayout.CENTER);
         if (presetHandler != null) {
@@ -141 +140 @@
      * internally and can be retrieved with {@link #getModel()}.
      */
     public TagEditorPanel(PresetHandler presetHandler) {
-        this(null, presetHandler);
+        this(null, presetHandler, 0);
     }
 
     /**
@@ -149 +148 @@
      * {@code model} is null, a new model is created.
      *
      * @param model the tag editor model
+     * @param maxCharacters maximum number of characters allowed, 0 for unlimited
      */
-    public TagEditorPanel(TagEditorModel model, PresetHandler presetHandler) {
+    public TagEditorPanel(TagEditorModel model, PresetHandler presetHandler, int maxCharacters) {
         this.model = model;
         this.presetHandler = presetHandler;
         if (this.model == null) {
             this.model = new TagEditorModel();
         }
+        this.tagTable = new TagTable(this.model, maxCharacters);
         build();
     }
 

src/org/openstreetmap/josm/gui/tagging/TagTable.java

@@ -392 +392 @@
 
     /**
      * initialize the table
+     * @param maxCharacters maximum number of characters allowed for keys and values, 0 for unlimited
      */
-    protected final void init() {
+    protected final void init(int maxCharacters) {
         setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
         setRowSelectionAllowed(true);
         setColumnSelectionAllowed(true);
@@ -425 +426 @@
 
         // create the table cell editor and set it to key and value columns
         //
-        TagCellEditor tmpEditor = new TagCellEditor();
+        TagCellEditor tmpEditor = new TagCellEditor(maxCharacters);
         setRowHeight(tmpEditor.getEditor().getPreferredSize().height);
         setTagCellEditor(tmpEditor);
     }
@@ -434 +435 @@
      * Creates a new tag table
      *
      * @param model the tag editor model
+     * @param maxCharacters maximum number of characters allowed for keys and values, 0 for unlimited
      */
-    public TagTable(TagEditorModel model) {
+    public TagTable(TagEditorModel model, int maxCharacters) {
         super(model, new TagTableColumnModel(model.getColumnSelectionModel()), model.getRowSelectionModel());
         this.model = model;
-        init();
+        init(maxCharacters);
     }
 
     @Override